Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: components/test_runner/test_plugin.h

Issue 1360123005: Enforce marking "override" for functions overriding Blink in components/test_runner/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/test_runner/spell_check_client.h ('k') | components/test_runner/web_content_settings.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/test_runner/test_plugin.h
diff --git a/components/test_runner/test_plugin.h b/components/test_runner/test_plugin.h
index efa0ca956050c3b4083d83cf56d1f52959567698..bb4ebc358e430d444a7f0db5237dc255ed13bfa1 100644
--- a/components/test_runner/test_plugin.h
+++ b/components/test_runner/test_plugin.h
@@ -58,39 +58,38 @@ class TestPlugin : public blink::WebPlugin, public cc::TextureLayerClient {
static bool IsSupportedMimeType(const blink::WebString& mime_type);
// WebPlugin methods:
- virtual bool initialize(blink::WebPluginContainer* container);
- virtual void destroy();
- virtual NPObject* scriptableObject();
- virtual bool canProcessDrag() const;
- virtual bool supportsKeyboardFocus() const;
- virtual void layoutIfNeeded() override { }
- virtual void paint(blink::WebCanvas* canvas, const blink::WebRect& rect) {}
- virtual void updateGeometry(
- const blink::WebRect& window_rect,
- const blink::WebRect& clip_rect,
- const blink::WebRect& unobscured_rect,
- const blink::WebVector<blink::WebRect>& cut_outs_rects,
- bool is_visible);
- virtual void updateFocus(bool focus, blink::WebFocusType focus_type) {}
- virtual void updateVisibility(bool visibility) {}
- virtual bool acceptsInputEvents();
- virtual bool handleInputEvent(const blink::WebInputEvent& event,
- blink::WebCursorInfo& info);
- virtual bool handleDragStatusUpdate(blink::WebDragStatus drag_status,
- const blink::WebDragData& data,
- blink::WebDragOperationsMask mask,
- const blink::WebPoint& position,
- const blink::WebPoint& screen_position);
- virtual void didReceiveResponse(const blink::WebURLResponse& response) {}
- virtual void didReceiveData(const char* data, int data_length) {}
- virtual void didFinishLoading() {}
- virtual void didFailLoading(const blink::WebURLError& error) {}
- virtual void didFinishLoadingFrameRequest(const blink::WebURL& url,
- void* notify_data) {}
- virtual void didFailLoadingFrameRequest(const blink::WebURL& url,
- void* notify_data,
- const blink::WebURLError& error) {}
- virtual bool isPlaceholder();
+ bool initialize(blink::WebPluginContainer* container) override;
+ void destroy() override;
+ NPObject* scriptableObject() override;
+ bool canProcessDrag() const override;
+ bool supportsKeyboardFocus() const override;
+ void layoutIfNeeded() override {}
+ void paint(blink::WebCanvas* canvas, const blink::WebRect& rect) override {}
+ void updateGeometry(const blink::WebRect& window_rect,
+ const blink::WebRect& clip_rect,
+ const blink::WebRect& unobscured_rect,
+ const blink::WebVector<blink::WebRect>& cut_outs_rects,
+ bool is_visible) override;
+ void updateFocus(bool focus, blink::WebFocusType focus_type) override {}
+ void updateVisibility(bool visibility) override {}
+ bool acceptsInputEvents() override;
+ bool handleInputEvent(const blink::WebInputEvent& event,
+ blink::WebCursorInfo& info) override;
+ bool handleDragStatusUpdate(blink::WebDragStatus drag_status,
+ const blink::WebDragData& data,
+ blink::WebDragOperationsMask mask,
+ const blink::WebPoint& position,
+ const blink::WebPoint& screen_position) override;
+ void didReceiveResponse(const blink::WebURLResponse& response) override {}
+ void didReceiveData(const char* data, int data_length) override {}
+ void didFinishLoading() override {}
+ void didFailLoading(const blink::WebURLError& error) override {}
+ void didFinishLoadingFrameRequest(const blink::WebURL& url,
+ void* notify_data) override {}
+ void didFailLoadingFrameRequest(const blink::WebURL& url,
+ void* notify_data,
+ const blink::WebURLError& error) override {}
+ bool isPlaceholder() override;
// cc::TextureLayerClient methods:
bool PrepareTextureMailbox(
« no previous file with comments | « components/test_runner/spell_check_client.h ('k') | components/test_runner/web_content_settings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698