Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Unified Diff: third_party/WebKit/Source/modules/permissions/PermissionsCallback.h

Issue 1360023005: permissions: remove duplicates from request multiple at the Blink level (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor-permissions
Patch Set: Address review comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/permissions/PermissionsCallback.h
diff --git a/third_party/WebKit/Source/modules/permissions/PermissionsCallback.h b/third_party/WebKit/Source/modules/permissions/PermissionsCallback.h
index feef2872bb09a55814d50f4825eef681094489fe..7d007f48722b2b325946611fb64fa6bb5c2188f1 100644
--- a/third_party/WebKit/Source/modules/permissions/PermissionsCallback.h
+++ b/third_party/WebKit/Source/modules/permissions/PermissionsCallback.h
@@ -26,7 +26,7 @@ class ScriptPromiseResolver;
class PermissionsCallback final
: public WebCallbacks<WebPassOwnPtr<WebVector<WebPermissionStatus>>, void> {
public:
- PermissionsCallback(ScriptPromiseResolver*, PassOwnPtr<WebVector<WebPermissionType>>);
+ PermissionsCallback(ScriptPromiseResolver*, PassOwnPtr<Vector<WebPermissionType>>, PassOwnPtr<Vector<int>>);
~PermissionsCallback() = default;
void onSuccess(WebPassOwnPtr<WebVector<WebPermissionStatus>>) override;
@@ -34,7 +34,8 @@ public:
private:
Persistent<ScriptPromiseResolver> m_resolver;
- OwnPtr<WebVector<WebPermissionType>> m_permissionTypes;
+ OwnPtr<Vector<WebPermissionType>> m_internalPermissions;
+ OwnPtr<Vector<int>> m_callerIndexToInternalIndex;
mlamouri (slow - plz ping) 2015/09/29 18:00:07 nit: those two things need comments.
Lalit Maganti 2015/10/02 13:57:25 Done.
WTF_MAKE_NONCOPYABLE(PermissionsCallback);
};

Powered by Google App Engine
This is Rietveld 408576698