permissions: remove duplicates from request multiple at the Blink level

third_party/WebKit/Source/modules/permissions/Permissions.cpp

Index: third_party/WebKit/Source/modules/permissions/Permissions.cpp
diff --git a/third_party/WebKit/Source/modules/permissions/Permissions.cpp b/third_party/WebKit/Source/modules/permissions/Permissions.cpp
index bd4029f2dd1cdca36636a84dfad180516d561838..5d717efcf05437bec1a0df07beed9337cc1a464e 100644
--- a/third_party/WebKit/Source/modules/permissions/Permissions.cpp
+++ b/third_party/WebKit/Source/modules/permissions/Permissions.cpp
@@ -23,6 +23,8 @@
 #include "platform/Logging.h"
 #include "public/platform/Platform.h"
 #include "public/platform/modules/permissions/WebPermissionClient.h"
+#include "wtf/NotFound.h"
+#include "wtf/Vector.h"
 
 namespace blink {
 
@@ -146,7 +148,8 @@ ScriptPromise Permissions::request(ScriptState* scriptState, const Vector<Dictio
         return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(InvalidStateError, "In its current state, the global scope can't request permissions."));
 
     ExceptionState exceptionState(ExceptionState::GetterContext,  "request", "Permissions", scriptState->context()->Global(), scriptState->isolate());
-    OwnPtr<WebVector<WebPermissionType>> permissions = adoptPtr(new WebVector<WebPermissionType>(rawPermissions.size()));
+    OwnPtr<Vector<WebPermissionType>> internalPermissions = adoptPtr(new Vector<WebPermissionType>());
+    OwnPtr<Vector<int>> callerIndexToInternalIndex = adoptPtr(new Vector<int>(rawPermissions.size()));
     for (size_t i = 0; i < rawPermissions.size(); ++i) {
         const Dictionary& rawPermission = rawPermissions[i];
 
@@ -154,13 +157,23 @@ ScriptPromise Permissions::request(ScriptState* scriptState, const Vector<Dictio
         if (exceptionState.hadException())
             return exceptionState.reject(scriptState);
 
-        permissions->operator[](i) = type.get();
+        int internalIndex;

[mlamouri (slow - plz ping), 2015/09/29 18:00:07]

nit: add a comment explaining what you are doing here (ie. resolving duplicates)

[Lalit Maganti, 2015/10/02 13:57:25]

Done.

+        auto it = internalPermissions->find(type.get());
+        if (it == kNotFound) {
+            internalIndex = internalPermissions->size();
+            internalPermissions->append(type.get());
+        } else {
+            internalIndex = it;
+        }
+        callerIndexToInternalIndex->operator[](i) = internalIndex;
     }
 
     ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
     ScriptPromise promise = resolver->promise();
 
-    client->requestPermissions(*permissions, KURL(KURL(), scriptState->executionContext()->securityOrigin()->toString()), new PermissionsCallback(resolver, permissions.release()));
+    WebVector<WebPermissionType> internalWebPermissions = *internalPermissions;
+    client->requestPermissions(internalWebPermissions, KURL(KURL(), scriptState->executionContext()->securityOrigin()->toString()),
+        new PermissionsCallback(resolver, internalPermissions.release(), callerIndexToInternalIndex.release()));
     return promise;
 }