Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Side by Side Diff: third_party/WebKit/Source/modules/permissions/PermissionsCallback.h

Issue 1360023005: permissions: remove duplicates from request multiple at the Blink level (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor-permissions
Patch Set: Address review comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef PermissionsCallback_h 5 #ifndef PermissionsCallback_h
6 #define PermissionsCallback_h 6 #define PermissionsCallback_h
7 7
8 #include "platform/heap/Handle.h" 8 #include "platform/heap/Handle.h"
9 #include "public/platform/WebCallbacks.h" 9 #include "public/platform/WebCallbacks.h"
10 #include "public/platform/WebPassOwnPtr.h" 10 #include "public/platform/WebPassOwnPtr.h"
11 #include "public/platform/WebVector.h" 11 #include "public/platform/WebVector.h"
12 #include "public/platform/modules/permissions/WebPermissionStatus.h" 12 #include "public/platform/modules/permissions/WebPermissionStatus.h"
13 #include "public/platform/modules/permissions/WebPermissionType.h" 13 #include "public/platform/modules/permissions/WebPermissionType.h"
14 #include "wtf/Noncopyable.h" 14 #include "wtf/Noncopyable.h"
15 #include "wtf/PassRefPtr.h" 15 #include "wtf/PassRefPtr.h"
16 #include "wtf/RefPtr.h" 16 #include "wtf/RefPtr.h"
17 17
18 namespace blink { 18 namespace blink {
19 19
20 class ScriptPromiseResolver; 20 class ScriptPromiseResolver;
21 21
22 // PermissionQueryCallback is an implementation of WebPermissionCallbacks 22 // PermissionQueryCallback is an implementation of WebPermissionCallbacks
23 // that will resolve the underlying promise depending on the result passed to 23 // that will resolve the underlying promise depending on the result passed to
24 // the callback. It takes a WebPermissionType in its constructor and will pass 24 // the callback. It takes a WebPermissionType in its constructor and will pass
25 // it to the PermissionStatus. 25 // it to the PermissionStatus.
26 class PermissionsCallback final 26 class PermissionsCallback final
27 : public WebCallbacks<WebPassOwnPtr<WebVector<WebPermissionStatus>>, void> { 27 : public WebCallbacks<WebPassOwnPtr<WebVector<WebPermissionStatus>>, void> {
28 public: 28 public:
29 PermissionsCallback(ScriptPromiseResolver*, PassOwnPtr<WebVector<WebPermissi onType>>); 29 PermissionsCallback(ScriptPromiseResolver*, PassOwnPtr<Vector<WebPermissionT ype>>, PassOwnPtr<Vector<int>>);
30 ~PermissionsCallback() = default; 30 ~PermissionsCallback() = default;
31 31
32 void onSuccess(WebPassOwnPtr<WebVector<WebPermissionStatus>>) override; 32 void onSuccess(WebPassOwnPtr<WebVector<WebPermissionStatus>>) override;
33 void onError() override; 33 void onError() override;
34 34
35 private: 35 private:
36 Persistent<ScriptPromiseResolver> m_resolver; 36 Persistent<ScriptPromiseResolver> m_resolver;
37 OwnPtr<WebVector<WebPermissionType>> m_permissionTypes; 37 OwnPtr<Vector<WebPermissionType>> m_internalPermissions;
38 OwnPtr<Vector<int>> m_callerIndexToInternalIndex;
mlamouri (slow - plz ping) 2015/09/29 18:00:07 nit: those two things need comments.
Lalit Maganti 2015/10/02 13:57:25 Done.
38 39
39 WTF_MAKE_NONCOPYABLE(PermissionsCallback); 40 WTF_MAKE_NONCOPYABLE(PermissionsCallback);
40 }; 41 };
41 42
42 } // namespace blink 43 } // namespace blink
43 44
44 #endif // PermissionsCallback_h 45 #endif // PermissionsCallback_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698