Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 1359833004: Stop supporting HW dither (Closed)

Created:
5 years, 3 months ago by bsalomon
Modified:
5 years, 3 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : minor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -98 lines) Patch
M gm/constcolorprocessor.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M include/gpu/GrPaint.h View 3 chunks +0 lines, -8 lines 0 comments Download
M include/gpu/SkGr.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrBlurUtils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrPaint.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrPipeline.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/gpu/GrPipeline.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M src/gpu/GrPipelineBuilder.h View 1 chunk +2 lines, -7 lines 0 comments Download
M src/gpu/GrPipelineBuilder.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrTextContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 16 chunks +18 lines, -21 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 3 chunks +7 lines, -24 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 5 chunks +1 line, -17 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
bsalomon
5 years, 3 months ago (2015-09-22 17:37:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359833004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359833004/20001
5 years, 3 months ago (2015-09-22 17:38:16 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 3 months ago (2015-09-22 17:38:17 UTC) #5
robertphillips
lgtm. Just to clarify: after this patch we will never use the HW dithering but, ...
5 years, 3 months ago (2015-09-22 18:34:57 UTC) #6
bsalomon
On 2015/09/22 18:34:57, robertphillips wrote: > lgtm. Just to clarify: after this patch we will ...
5 years, 3 months ago (2015-09-22 18:37:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359833004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359833004/20001
5 years, 3 months ago (2015-09-22 18:37:53 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 18:38:50 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/aca31fea8ca620bfdb2887641b7ba56e401a72d7

Powered by Google App Engine
This is Rietveld 408576698