Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 1358393004: Remove crash-hunting instrumentation that has served its purpose. (Closed)

Created:
5 years, 3 months ago by Jakob Kummerow
Modified:
5 years, 3 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove crash-hunting instrumentation that has served its purpose. BUG=chromium:527994 LOG=n Committed: https://crrev.com/3e58db33e3726cf10f60361ef70839e6bed733af Cr-Commit-Position: refs/heads/master@{#30889}

Patch Set 1 #

Patch Set 2 : remove unused variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -132 lines) Patch
M src/builtins.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M src/ic/arm/ic-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/arm64/ic-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ia32/ic-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ic.h View 1 chunk +2 lines, -10 lines 0 comments Download
M src/ic/ic.cc View 2 chunks +0 lines, -22 lines 0 comments Download
M src/ic/mips/ic-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/mips64/ic-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ppc/ic-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/x64/ic-x64.cc View 1 2 chunks +1 line, -31 lines 0 comments Download
M src/ic/x87/ic-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Jakob Kummerow
While we can't be sure yet whether we've fixed the bug, there's nothing to be ...
5 years, 3 months ago (2015-09-23 11:56:39 UTC) #2
mvstanton
always nice to remove such instrumentation :). LGTM.
5 years, 3 months ago (2015-09-23 12:36:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358393004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358393004/20001
5 years, 3 months ago (2015-09-23 12:49:42 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-23 13:48:07 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 13:48:14 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3e58db33e3726cf10f60361ef70839e6bed733af
Cr-Commit-Position: refs/heads/master@{#30889}

Powered by Google App Engine
This is Rietveld 408576698