Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Unified Diff: src/hydrogen.cc

Issue 1358393004: Remove crash-hunting instrumentation that has served its purpose. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: remove unused variable Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/full-codegen/x64/full-codegen-x64.cc ('k') | src/ic/arm/ic-arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index eef51e5d952ceddd572edc2e05cd03a3fde2e52c..5f1af6be3f972e4d70496c9e45c0817d891ec693 100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -9626,29 +9626,6 @@ void HOptimizedGraphBuilder::VisitCall(Call* expr) {
CHECK_ALIVE(VisitForValue(prop->obj()));
HValue* receiver = Top();
- // Sanity check: The receiver must be a JS-exposed kind of object,
- // not something internal (like a Map, or FixedArray). Check this here
- // to chase after a rare but recurring crash bug. It seems to always
- // occur for functions beginning with "this.foo.bar()", so be selective
- // and only insert the check for the first call (identified by slot).
- // TODO(chromium:527994): Remove this when we have a few crash reports.
- if (prop->key()->IsPropertyName() &&
- prop->PropertyFeedbackSlot().ToInt() == 2) {
- IfBuilder if_heapobject(this);
- if_heapobject.IfNot<HIsSmiAndBranch>(receiver);
- if_heapobject.Then();
- {
- IfBuilder special_map(this);
- Factory* factory = isolate()->factory();
- special_map.If<HCompareMap>(receiver, factory->fixed_array_map());
- special_map.OrIf<HCompareMap>(receiver, factory->meta_map());
- special_map.Then();
- Add<HDebugBreak>();
- special_map.End();
- }
- if_heapobject.End();
- }
-
SmallMapList* maps;
ComputeReceiverTypes(expr, receiver, &maps, zone());
« no previous file with comments | « src/full-codegen/x64/full-codegen-x64.cc ('k') | src/ic/arm/ic-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698