Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Unified Diff: src/ic/ic.cc

Issue 1358393004: Remove crash-hunting instrumentation that has served its purpose. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: remove unused variable Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ic/ic.h ('k') | src/ic/mips/ic-mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ic/ic.cc
diff --git a/src/ic/ic.cc b/src/ic/ic.cc
index 99a79d93688091799a237bff03cf9cd214542be2..23944028a6466cb172aaf41c85903ff8cb553f57 100644
--- a/src/ic/ic.cc
+++ b/src/ic/ic.cc
@@ -2377,17 +2377,6 @@ RUNTIME_FUNCTION(Runtime_LoadIC_Miss) {
LoadIC ic(IC::NO_EXTRA_FRAME, isolate, &nexus);
ic.UpdateState(receiver, key);
ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, result, ic.Load(receiver, key));
-
- // Sanity check: The loaded value must be a JS-exposed kind of object,
- // not something internal (like a Map, or FixedArray). Check this here
- // to chase after a rare but recurring crash bug.
- // TODO(chromium:527994): Remove this when we have a few crash reports.
- if (!result->IsSmi()) {
- InstanceType type =
- Handle<HeapObject>::cast(result)->map()->instance_type();
- CHECK(type <= LAST_PRIMITIVE_TYPE || type >= FIRST_JS_RECEIVER_TYPE);
- }
-
} else {
DCHECK(vector->GetKind(vector_slot) == Code::KEYED_LOAD_IC);
KeyedLoadICNexus nexus(vector, vector_slot);
@@ -3126,17 +3115,6 @@ RUNTIME_FUNCTION(Runtime_LoadIC_MissFromStubFailure) {
LoadIC ic(IC::EXTRA_CALL_FRAME, isolate, &nexus);
ic.UpdateState(receiver, key);
ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, result, ic.Load(receiver, key));
-
- // Sanity check: The loaded value must be a JS-exposed kind of object,
- // not something internal (like a Map, or FixedArray). Check this here
- // to chase after a rare but recurring crash bug.
- // TODO(chromium:527994): Remove this when we have a few crash reports.
- if (!result->IsSmi()) {
- InstanceType type =
- Handle<HeapObject>::cast(result)->map()->instance_type();
- CHECK(type <= LAST_PRIMITIVE_TYPE || type >= FIRST_JS_RECEIVER_TYPE);
- }
-
} else {
DCHECK(vector->GetKind(vector_slot) == Code::KEYED_LOAD_IC);
KeyedLoadICNexus nexus(vector, vector_slot);
« no previous file with comments | « src/ic/ic.h ('k') | src/ic/mips/ic-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698