Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 1357983002: Invert pain to comfort throughout tracing. (Closed)

Created:
5 years, 3 months ago by benjhayden
Modified:
5 years, 2 months ago
Reviewers:
nduca
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Base URL:
https://github.com/catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -141 lines) Patch
M tracing/tracing/extras/rail/animation_interaction_record.html View 2 chunks +19 lines, -20 lines 0 comments Download
M tracing/tracing/extras/rail/animation_interaction_record_test.html View 3 chunks +10 lines, -10 lines 0 comments Download
M tracing/tracing/extras/rail/idle_interaction_record.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/extras/rail/idle_interaction_record_test.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/extras/rail/load_interaction_record.html View 2 chunks +8 lines, -8 lines 0 comments Download
M tracing/tracing/extras/rail/rail_interaction_record.html View 7 chunks +54 lines, -50 lines 0 comments Download
M tracing/tracing/extras/rail/rail_interaction_record_test.html View 6 chunks +28 lines, -23 lines 0 comments Download
M tracing/tracing/extras/rail/rail_ir_finder.html View 1 chunk +4 lines, -4 lines 0 comments Download
M tracing/tracing/extras/rail/response_interaction_record.html View 2 chunks +10 lines, -10 lines 0 comments Download
M tracing/tracing/extras/rail/response_interaction_record_test.html View 1 chunk +12 lines, -4 lines 0 comments Download
M tracing/tracing/extras/rail/stub_rail_interaction_record.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/model/interaction_record_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/extras/rail/rail_score_side_panel.html View 1 chunk +3 lines, -3 lines 0 comments Download
M tracing/tracing/ui/extras/rail/rail_score_side_panel_test.html View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
benjhayden
5 years, 2 months ago (2015-10-05 20:23:38 UTC) #5
nduca
lgtm but please update go/railscore
5 years, 2 months ago (2015-10-05 20:27:18 UTC) #6
benjhayden
On 2015/10/05 at 20:27:18, nduca wrote: > lgtm but please update go/railscore Done.
5 years, 2 months ago (2015-10-05 20:30:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1357983002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1357983002/60001
5 years, 2 months ago (2015-10-05 20:32:21 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 20:40:19 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:60001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698