Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: tracing/tracing/extras/rail/response_interaction_record.html

Issue 1357983002: Invert pain to comfort throughout tracing. (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: . Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/extras/rail/response_interaction_record.html
diff --git a/tracing/tracing/extras/rail/response_interaction_record.html b/tracing/tracing/extras/rail/response_interaction_record.html
index eb29d6bfc0968141a0184b8e25a6b002531b4420..7840d5554a56b45375c60001a3530abca095831e 100644
--- a/tracing/tracing/extras/rail/response_interaction_record.html
+++ b/tracing/tracing/extras/rail/response_interaction_record.html
@@ -13,9 +13,9 @@ found in the LICENSE file.
* @fileoverview The Response phase of RAIL.
*/
tr.exportTo('tr.e.rail', function() {
- // The computeNormalizedPain regions are delineated at these millisecond
+ // The computeNormalizedComfort regions are delineated at these millisecond
// latency values.
- var PAIN_LATENCY_REGIONS = [150, 300, 1000, 5000];
+ var COMFORT_LATENCY_REGIONS = [150, 300, 1000, 5000];
function ResponseInteractionRecord(start, duration) {
tr.e.rail.RAILInteractionRecord.call(
@@ -26,22 +26,22 @@ tr.exportTo('tr.e.rail', function() {
ResponseInteractionRecord.prototype = {
__proto__: tr.e.rail.RAILInteractionRecord.prototype,
- get normalizedUserPain() {
- // User pain is derived from the time between when the user thinks they
+ get normalizedUserComfort() {
+ // User comfort is derived from the time between when the user thinks they
// begin an interation (expectedStart) and the time when the screen first
// changes to reflect the interaction (actualEnd). There may be a delay
// between expectedStart and when chrome first starts processing the
// interaction (actualStart) if the main thread is busy. The user doesn't
// know when actualStart is, they only know when expectedStart is. User
- // pain, by definition, considers only what the user experiences, so
+ // comfort, by definition, considers only what the user experiences, so
// "duration" is defined as actualEnd - expectedStart.
// https://www.desmos.com/calculator/xa9setwcmf
- return tr.e.rail.computeNormalizedPain(this.duration, {
- minValueExponential: PAIN_LATENCY_REGIONS[0],
- minValueLinear: PAIN_LATENCY_REGIONS[1],
- minValueLogarithmic: PAIN_LATENCY_REGIONS[2],
- maxValue: PAIN_LATENCY_REGIONS[3]
+ return 1 - tr.e.rail.computeNormalizedComfort(this.duration, {
+ minValueExponential: COMFORT_LATENCY_REGIONS[0],
+ minValueLinear: COMFORT_LATENCY_REGIONS[1],
+ minValueLogarithmic: COMFORT_LATENCY_REGIONS[2],
+ maxValue: COMFORT_LATENCY_REGIONS[3]
});
}
};
« no previous file with comments | « tracing/tracing/extras/rail/rail_ir_finder.html ('k') | tracing/tracing/extras/rail/response_interaction_record_test.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698