Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 1368553002: Revert of [Android]Don't check for child account/EDU device for every activity. (Closed)

Created:
5 years, 3 months ago by dcheng
Modified:
5 years, 3 months ago
Reviewers:
Bernhard Bauer, knn
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android]Don't check for child account/EDU device for every activity. (patchset #3 id:40001 of https://codereview.chromium.org/1357643002/ ) Reason for revert: Breaks git on case-insensitive filesystems. Original issue's description: > [Android]Don't check for child account/EDU device for every activity. > > Extract a Forced Signin Processor out of FirstRun Signin Processor which > checks for child accounts and EDU device and is only triggered: > -Once per Chrome Application startup. > -On updates to accounts on the device. > > Invariants: > FRE ToS checks and FRE pending signin checks still happen on every activity for now. > > Dependent patchsets: > http://crrev.com/1341423005 > http://crrev.com/1353393002 > > BUG=518830 > > Committed: https://crrev.com/b022082dde8822156eb2fcd3a1c156b566119521 > Cr-Commit-Position: refs/heads/master@{#350133} TBR=bauerb@chromium.org,knn@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=518830 Committed: https://chromium.googlesource.com/chromium/src/+/6cb79385a014dd500f3a81bb72db315fdb27bc12

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+346 lines, -355 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java View 3 chunks +0 lines, -14 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java View 3 chunks +2 lines, -6 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunSignInProcessor.java View 1 chunk +319 lines, -0 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunSigninProcessor.java View 1 chunk +0 lines, -236 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/firstrun/ForcedSigninProcessor.java View 1 chunk +0 lines, -71 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/SignInPreference.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/services/AndroidEduAndChildAccountHelper.java View 3 chunks +11 lines, -14 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/FirstRunTest.java View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
dcheng
Created Revert of [Android]Don't check for child account/EDU device for every activity.
5 years, 3 months ago (2015-09-23 23:35:55 UTC) #1
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6cb79385a014dd500f3a81bb72db315fdb27bc12 Cr-Commit-Position: refs/heads/master@{#350389}
5 years, 3 months ago (2015-09-23 23:38:23 UTC) #3
dcheng
5 years, 3 months ago (2015-09-23 23:38:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6cb79385a014dd500f3a81bb72db315fdb27bc12 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698