ChildAccountService[Java] delegates everything to native side.

ChildAccountService[Java] delegates everything to native side.

Most of the child account detection/enforcement logic has been divided amongst
the ChildAccountInfoFetcher and ForcedSigninProcessor.

ForcedSigninProcessor will make sure that child accounts are detected and
are signed in.
ChildAccountInfoFetcher only activates on signin and informs the
native ChildAccountService about the child account and takes responsiblity for
any further updates (graduation) or account changes.

Depends on http://crrev.com/1357643002
Dependent patchset http://crrev.com/1353393002

BUG=518830
Committed: https://crrev.com/1c628b552ba2f3619518c22f25ef983e81490831
Cr-Commit-Position: refs/heads/master@{#350138}

[knn, 2015-09-21 14:13:13]

knn@chromium.org changed reviewers:
+ bauerb@chromium.org

[knn, 2015-09-21 14:13:14]

PTAL part 2 of the change.
Added comments in ChildAccountService and the issue description.

[Bernhard Bauer, 2015-09-21 14:29:38]

LGTM w/ comment nits:

https://codereview.chromium.org/1341423005/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/childaccounts/ChildAccountService.java
(right):

https://codereview.chromium.org/1341423005/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/childaccounts/ChildAccountService.java:23:
* checkHasChildAccount(...) which is asynchronous and queries the system
directly for the
This should fit on the previous line, right?

https://codereview.chromium.org/1341423005/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/childaccounts/ChildAccountService.java:25:
* the synchronous isChildAccount() which asks the native side.
...but relies on the flag on the native side having been already set correctly.

[knn, 2015-09-21 14:42:02]

The CQ bit was checked by knn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-21 14:42:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1341423005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1341423005/20001

[commit-bot: I haz the power, 2015-09-21 14:43:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-21 14:43:55]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[knn, 2015-09-21 14:53:03]

Thanks!

https://codereview.chromium.org/1341423005/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/childaccounts/ChildAccountService.java
(right):

https://codereview.chromium.org/1341423005/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/childaccounts/ChildAccountService.java:23:
* checkHasChildAccount(...) which is asynchronous and queries the system
directly for the
On 2015/09/21 14:29:37, Bernhard Bauer wrote:
> This should fit on the previous line, right?

Yes, it is my failed attempt at trying to divide the comment into 2 bullets.
Done.

https://codereview.chromium.org/1341423005/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/childaccounts/ChildAccountService.java:25:
* the synchronous isChildAccount() which asks the native side.
On 2015/09/21 14:29:37, Bernhard Bauer wrote:
> ...but relies on the flag on the native side having been already set
correctly.

Done.

[Bernhard Bauer, 2015-09-21 15:18:14]

https://codereview.chromium.org/1341423005/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/childaccounts/ChildAccountService.java
(right):

https://codereview.chromium.org/1341423005/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/childaccounts/ChildAccountService.java:23:
* checkHasChildAccount(...) which is asynchronous and queries the system
directly for the
On 2015/09/21 14:53:03, knn wrote:
> On 2015/09/21 14:29:37, Bernhard Bauer wrote:
> > This should fit on the previous line, right?
> 
> Yes, it is my failed attempt at trying to divide the comment into 2 bullets.
> Done.

Oh, now I get it! That actually does make sense, but you need to make sure the
bullet points stand out from the comment markers. Also, if you change to a
bullet point style, you don't need to write full sentences anymore (which led me
to thinking the comment was just an awkwardly broken sentence).

[knn, 2015-09-22 10:16:40]

The CQ bit was checked by knn@chromium.org

[knn, 2015-09-22 10:16:41]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/1341423005/#ps20001
(title: "nits")

[commit-bot: I haz the power, 2015-09-22 10:16:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1341423005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1341423005/20001

[commit-bot: I haz the power, 2015-09-22 11:14:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-22 11:15:02]

Patchset 2 (id:??) landed as
https://crrev.com/1c628b552ba2f3619518c22f25ef983e81490831
Cr-Commit-Position: refs/heads/master@{#350138}

[dcheng, 2015-09-23 23:24:15]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1367783002/ by dcheng@chromium.org.

The reason for reverting is: Depends on
https://codereview.chromium.org/1357643002, which is being reverted..

[dcheng, 2015-09-23 23:28:35]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1362723006/ by dcheng@chromium.org.

The reason for reverting is: This patch breaks git on case-insensitive
filesystems..