Issue 1357563002: Expose FormatUrlForSecurityDisplay to Java on Android.

Issue 1357563002: Expose FormatUrlForSecurityDisplay to Java on Android. (Closed)

Created:
5 years, 3 months ago by palmer

Modified:
5 years, 3 months ago

Reviewers:
Ted C

CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Expose FormatUrlForSecurityDisplay to Java on Android. BUG=508371 Committed: https://crrev.com/912469298b1b5af90ca384ecea84e98f83724181 Cr-Commit-Position: refs/heads/master@{#349886}

Patch Set 1 #

Patch Set 2 : Tweak tests. #

Patch Set 3 : Attempt to build and link the JNI bits. #

Patch Set 4 : Fix typo. #

Patch Set 5 : Remove unnecessary stuff. #

Patch Set 6 : Using a fake scheme in the test makes formatUrlForSecurityDisplay be conservative, breaking the tes… #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -45 lines)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/UrlUtilities.java	View		2 chunks	+6 lines, -22 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappUrlBar.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/android/javatests/src/org/chromium/chrome/browser/UrlUtilitiesTest.java	View	1 2 3 4	2 chunks	+21 lines, -17 lines	0 comments	Download
M	chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappUrlBarTest.java	View	1 2 3 4 5	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/android/url_utilities.cc	View		2 chunks	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 12 (5 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1357563002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1357563002/80001

5 years, 3 months ago (2015-09-18 22:39:49 UTC) #5

commit-bot: I haz the power

Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/71230)

5 years, 3 months ago (2015-09-19 00:47:40 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1357563002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1357563002/100001

5 years, 3 months ago (2015-09-20 22:31:55 UTC) #10

commit-bot: I haz the power

5 years, 3 months ago (2015-09-20 23:17:09 UTC) #12

Message was sent while issue was closed.

Patchset 6 (id:??) landed as
https://crrev.com/912469298b1b5af90ca384ecea84e98f83724181
Cr-Commit-Position: refs/heads/master@{#349886}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages