chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappUrlBarTest.java - Issue 1357563002: Expose FormatUrlForSecurityDisplay to Java on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappUrlBarTest.java

Issue 1357563002: Expose FormatUrlForSecurityDisplay to Java on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Using a fake scheme in the test makes formatUrlForSecurityDisplay be conservative, breaking the tes… Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/UrlUtilitiesTest.java ('k') | chrome/browser/android/url_utilities.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappUrlBarTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappUrlBarTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappUrlBarTest.java

index 0721b9fc431a79f579acb3956f1dcdc264e2f281..48e94974bab63dc279e7705bc620669a0db1d94a 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappUrlBarTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappUrlBarTest.java

@@ -36,7 +36,7 @@ public class WebappUrlBarTest extends WebappActivityTestBase {

@MediumTest

@Feature({"Webapps"})

public void testUrlDisplay() {

- final String scheme = "somescheme://";

+ final String scheme = "https://";

final String host = "lorem.com";

final String path = "/stuff/and/things.html";

final String url = scheme + host + path;

@@ -49,7 +49,7 @@ public class WebappUrlBarTest extends WebappActivityTestBase {

ConnectionSecurityLevel.SECURITY_ERROR};

for (int i : securityLevels) {

- // http://crbug.com/297249

+ // TODO(palmer): http://crbug.com/297249

if (i == ConnectionSecurityLevel.SECURITY_POLICY_WARNING) continue;

mUrlBar.update(url, i);