chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java - Issue 1357563002: Expose FormatUrlForSecurityDisplay to Java on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java

Issue 1357563002: Expose FormatUrlForSecurityDisplay to Java on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Using a fake scheme in the test makes formatUrlForSecurityDisplay be conservative, breaking the tes… Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappUrlBar.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java

index 3b8915a8dfbd792d65e803979d2ad6564a7f28f3..514b5edc3ce7e65de39c1865472198eff9bede20 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java

@@ -131,7 +131,8 @@ public class SingleWebsitePreferences extends PreferenceFragment

Bundle fragmentArgs = new Bundle();

// TODO(mvanouwerkerk): Define a pure getOrigin method in UrlUtilities that is the

// equivalent of the call below, because this is perfectly fine for non-display purposes.

- String origin = UrlUtilities.getOriginForDisplay(URI.create(url), true /* schowScheme */);

+ String origin =

+ UrlUtilities.formatUrlForSecurityDisplay(URI.create(url), true /* showScheme */);

fragmentArgs.putString(SingleWebsitePreferences.EXTRA_ORIGIN, origin);

return fragmentArgs;

}