Desktop context menu reorganisation

chrome/browser/renderer_context_menu/spelling_menu_observer_browsertest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_context_menu/spelling_menu_observer.h"
 
 #include <vector>
 
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 246 matching lines @@
 }
 
 }  // namespace
 
 // Tests that right-clicking a correct word does not add any items.
 IN_PROC_BROWSER_TEST_F(SpellingMenuObserverTest, InitMenuWithCorrectWord) {
   InitMenu("", NULL);
   EXPECT_EQ(static_cast<size_t>(0), menu()->GetMenuSize());
 }
 
-// Tests that right-clicking a misspelled word adds four items:
-// "No spelling suggestions", "Add to dictionary", "Ask Google for suggestions",
-// and a separator.
+// Tests that right-clicking a misspelled word adds three items:
+// "Add to dictionary", "Ask Google for suggestions",and a separator.

[Avi (use Gerrit), 2015/09/26 02:26:15]

space after a comma

[edwardjung, 2015/09/28 14:11:26]

Done.

 IN_PROC_BROWSER_TEST_F(SpellingMenuObserverTest, InitMenuWithMisspelledWord) {
   InitMenu("wiimode", NULL);
-  EXPECT_EQ(static_cast<size_t>(4), menu()->GetMenuSize());
+  EXPECT_EQ(static_cast<size_t>(3), menu()->GetMenuSize());

[Avi (use Gerrit), 2015/09/26 02:26:15]

er, just do 3u

[edwardjung, 2015/09/28 14:11:25]

Hadn't realised this. Done.

 
   // Read all the context-menu items added by this test and verify they are
   // expected ones. We do not check the item titles to prevent resource changes
   // from breaking this test. (I think it is not expected by those who change
   // resources.)
   MockRenderViewContextMenu::MockMenuItem item;
   menu()->GetMenuItem(0, &item);
-  EXPECT_EQ(IDC_CONTENT_CONTEXT_NO_SPELLING_SUGGESTIONS, item.command_id);
-  EXPECT_FALSE(item.enabled);
-  EXPECT_FALSE(item.hidden);
-  menu()->GetMenuItem(1, &item);
   EXPECT_EQ(IDC_SPELLCHECK_ADD_TO_DICTIONARY, item.command_id);
   EXPECT_TRUE(item.enabled);
   EXPECT_FALSE(item.hidden);
-  menu()->GetMenuItem(2, &item);
+  menu()->GetMenuItem(1, &item);
   EXPECT_EQ(IDC_CONTENT_CONTEXT_SPELLING_TOGGLE, item.command_id);
   EXPECT_TRUE(item.enabled);
   EXPECT_FALSE(item.checked);
   EXPECT_FALSE(item.hidden);
-  menu()->GetMenuItem(3, &item);
+  menu()->GetMenuItem(2, &item);
   EXPECT_EQ(-1, item.command_id);
   EXPECT_FALSE(item.enabled);
   EXPECT_FALSE(item.hidden);
 }
 
 // Tests that right-clicking a correct word when we enable spelling-service
 // integration to verify an item "Ask Google for suggestions" is checked. Even
 // though this meanu itself does not add this item, its sub-menu adds the item
 // and calls SpellingMenuObserver::IsChecked() to check it.
 IN_PROC_BROWSER_TEST_F(SpellingMenuObserverTest,
                        EnableSpellingServiceWithCorrectWord) {
   menu()->GetPrefs()->SetBoolean(prefs::kSpellCheckUseSpellingService, true);
   InitMenu("", NULL);
 
   EXPECT_TRUE(
       observer()->IsCommandIdChecked(IDC_CONTENT_CONTEXT_SPELLING_TOGGLE));
 }
 
 // Tests that right-clicking a misspelled word when we enable spelling-service
 // integration to verify an item "Ask Google for suggestions" is checked. (This
 // test does not actually send JSON-RPC requests to the service because it makes
 // this test flaky.)
 IN_PROC_BROWSER_TEST_F(SpellingMenuObserverTest, EnableSpellingService) {
   menu()->GetPrefs()->SetBoolean(prefs::kSpellCheckUseSpellingService, true);
   base::ListValue dictionary;
   menu()->GetPrefs()->Set(prefs::kSpellCheckDictionaries, dictionary);
 
   InitMenu("wiimode", NULL);
-  EXPECT_EQ(static_cast<size_t>(4), menu()->GetMenuSize());
+  EXPECT_EQ(static_cast<size_t>(3), menu()->GetMenuSize());

[Avi (use Gerrit), 2015/09/26 02:26:15]

3u

[edwardjung, 2015/09/28 14:11:25]

Done.

 
   // To avoid duplicates, this test reads only the "Ask Google for suggestions"
   // item and verifies it is enabled and checked.
   MockRenderViewContextMenu::MockMenuItem item;
-  menu()->GetMenuItem(2, &item);
+  menu()->GetMenuItem(1, &item);
   EXPECT_EQ(IDC_CONTENT_CONTEXT_SPELLING_TOGGLE, item.command_id);
   EXPECT_TRUE(item.enabled);
   EXPECT_TRUE(item.checked);
   EXPECT_FALSE(item.hidden);
 }
 
-// Test that there will be a separator after "no suggestions" if
-// SpellingServiceClient::SUGGEST is on.
-IN_PROC_BROWSER_TEST_F(SpellingMenuObserverTest, SeparatorAfterSuggestions) {
-  ForceSuggestMode();
-  InitMenu("jhhj", NULL);
-
-  // The test should see a top separator, "No spelling suggestions",
-  // "No more Google suggestions" (from SpellingService) and a separator
-  // as the first four items, then possibly more (not relevant here).
-  EXPECT_LT(4U, menu()->GetMenuSize());
-
-  MockRenderViewContextMenu::MockMenuItem item;
-  menu()->GetMenuItem(0, &item);
-  EXPECT_EQ(-1, item.command_id);
-  EXPECT_FALSE(item.enabled);
-  EXPECT_FALSE(item.hidden);
-
-  menu()->GetMenuItem(1, &item);
-  EXPECT_EQ(IDC_CONTENT_CONTEXT_SPELLING_SUGGESTION, item.command_id);
-  EXPECT_FALSE(item.enabled);
-  EXPECT_FALSE(item.hidden);
-
-  menu()->GetMenuItem(2, &item);
-  EXPECT_EQ(IDC_CONTENT_CONTEXT_NO_SPELLING_SUGGESTIONS, item.command_id);
-  EXPECT_FALSE(item.enabled);
-  EXPECT_FALSE(item.hidden);
-
-  menu()->GetMenuItem(3, &item);
-  EXPECT_EQ(-1, item.command_id);
-  EXPECT_FALSE(item.enabled);
-  EXPECT_FALSE(item.hidden);
-}
-
 // Test that we don't show "No more suggestions from Google" if the spelling
 // service is enabled and that there is only one suggestion.
 IN_PROC_BROWSER_TEST_F(SpellingMenuObserverTest,
                        NoMoreSuggestionsNotDisplayed) {
   menu()->GetPrefs()->SetBoolean(prefs::kSpellCheckUseSpellingService, true);
 
   // Force a non-empty locale so SPELLCHECK is available.
   base::ListValue dictionary;
   dictionary.AppendString("en");
   menu()->GetPrefs()->Set(prefs::kSpellCheckDictionaries, dictionary);
 
   EXPECT_TRUE(SpellingServiceClient::IsAvailable(
       menu()->GetBrowserContext(), SpellingServiceClient::SPELLCHECK));
   InitMenu("asdfkj", "asdf");
 
-  // The test should see a separator, a suggestion and another separator
-  // as the first two items, then possibly more (not relevant here).
+  // The test should see a separator, suggestion, "Add to dictionary",
+  // "Ask Google for suggestions",and a separator.

[Avi (use Gerrit), 2015/09/26 02:26:15]

space after a comma

[edwardjung, 2015/09/28 14:11:25]

Done.

+  // Possibly more items (not relevant here).

[Avi (use Gerrit), 2015/09/26 02:26:15]

Combine this comment line with the previous one.

[edwardjung, 2015/09/28 14:11:26]

Done.

   EXPECT_LT(3U, menu()->GetMenuSize());
 
   MockRenderViewContextMenu::MockMenuItem item;
   menu()->GetMenuItem(0, &item);
   EXPECT_EQ(-1, item.command_id);
   EXPECT_FALSE(item.enabled);
   EXPECT_FALSE(item.hidden);
 
   menu()->GetMenuItem(1, &item);
   EXPECT_EQ(IDC_SPELLCHECK_SUGGESTION_0, item.command_id);
   EXPECT_TRUE(item.enabled);
   EXPECT_FALSE(item.hidden);
 
   menu()->GetMenuItem(2, &item);
+  EXPECT_EQ(IDC_SPELLCHECK_ADD_TO_DICTIONARY, item.command_id);
+  EXPECT_TRUE(item.enabled);
+  EXPECT_FALSE(item.hidden);
+
+  menu()->GetMenuItem(3, &item);
+  EXPECT_EQ(IDC_CONTENT_CONTEXT_SPELLING_TOGGLE, item.command_id);
+  EXPECT_TRUE(item.enabled);
+  EXPECT_TRUE(item.checked);
+  EXPECT_FALSE(item.hidden);
+
+  menu()->GetMenuItem(4, &item);
   EXPECT_EQ(-1, item.command_id);
   EXPECT_FALSE(item.enabled);
   EXPECT_FALSE(item.hidden);
 }
 
 // Test that "Ask Google For Suggestions" is grayed out when using an
 // off the record profile.
 // TODO(rlp): Include graying out of autocorrect in this test when autocorrect
 // is functional.
 IN_PROC_BROWSER_TEST_F(SpellingMenuObserverTest,
@@ skipping 11 matching lines @@
   dictionary.AppendString("en");
   menu()->GetPrefs()->Set(prefs::kSpellCheckDictionaries, dictionary);
 
   EXPECT_FALSE(SpellingServiceClient::IsAvailable(
       menu()->GetBrowserContext(), SpellingServiceClient::SUGGEST));
   EXPECT_FALSE(SpellingServiceClient::IsAvailable(
       menu()->GetBrowserContext(), SpellingServiceClient::SPELLCHECK));
 
   InitMenu("sjxdjiiiiii", NULL);
 
-  // The test should see "No spelling suggestions" (from system checker).
   // They should not see "No more Google suggestions" (from SpellingService) or

[Avi (use Gerrit), 2015/09/26 02:26:15]

Who is "they"? Maybe "There should not be xxxx nor xxxx".

[edwardjung, 2015/09/28 14:11:25]

Done.

   // a separator. The next 2 items should be "Add to Dictionary" followed
   // by "Ask Google for suggestions" which should be disabled.
   // TODO(rlp): add autocorrect here when it is functional.
-  EXPECT_LT(3U, menu()->GetMenuSize());
+  EXPECT_LT(2U, menu()->GetMenuSize());
 
   MockRenderViewContextMenu::MockMenuItem item;
   menu()->GetMenuItem(0, &item);
-  EXPECT_EQ(IDC_CONTENT_CONTEXT_NO_SPELLING_SUGGESTIONS, item.command_id);
-  EXPECT_FALSE(item.enabled);
-  EXPECT_FALSE(item.hidden);
-
-  menu()->GetMenuItem(1, &item);
   EXPECT_EQ(IDC_SPELLCHECK_ADD_TO_DICTIONARY, item.command_id);
   EXPECT_TRUE(item.enabled);
   EXPECT_FALSE(item.hidden);
 
-  menu()->GetMenuItem(2, &item);
+  menu()->GetMenuItem(1, &item);
   EXPECT_EQ(IDC_CONTENT_CONTEXT_SPELLING_TOGGLE, item.command_id);
   EXPECT_FALSE(item.enabled);
   EXPECT_FALSE(item.hidden);
 }
 
 // Test that the menu is preceeded by a separator if there are any suggestions,
 // or if the SpellingServiceClient is available
 IN_PROC_BROWSER_TEST_F(SpellingMenuObserverTest, SuggestionsForceTopSeparator) {
   menu()->GetPrefs()->SetBoolean(prefs::kSpellCheckUseSpellingService, false);
 
   // First case: Misspelled word, no suggestions, no spellcheck service.
   InitMenu("asdfkj", NULL);
-  // See SpellingMenuObserverTest.InitMenuWithMisspelledWord on why 4 items.
-  EXPECT_EQ(static_cast<size_t>(4), menu()->GetMenuSize());
+  // See SpellingMenuObserverTest.InitMenuWithMisspelledWord on why 3 items.
+  EXPECT_EQ(static_cast<size_t>(3), menu()->GetMenuSize());

[Avi (use Gerrit), 2015/09/26 02:26:15]

3u

[edwardjung, 2015/09/28 14:11:25]

Done.

   MockRenderViewContextMenu::MockMenuItem item;
   menu()->GetMenuItem(0, &item);
   EXPECT_NE(-1, item.command_id);
 
   // Case #2. Misspelled word, suggestions, no spellcheck service.
   Reset(false);
   menu()->GetPrefs()->SetBoolean(prefs::kSpellCheckUseSpellingService, false);
   InitMenu("asdfkj", "asdf");
 
   // Expect at least separator and 4 default entries.
-  EXPECT_LT(static_cast<size_t>(5), menu()->GetMenuSize());
+  EXPECT_LT(static_cast<size_t>(4), menu()->GetMenuSize());

[Avi (use Gerrit), 2015/09/26 02:26:15]

4u

[edwardjung, 2015/09/28 14:11:25]

Done.

   // This test only cares that the first one is a separator.
   menu()->GetMenuItem(0, &item);
   EXPECT_EQ(-1, item.command_id);
 
   // Case #3. Misspelled word, suggestion service is on.
   Reset(false);
   ForceSuggestMode();
   InitMenu("asdfkj", NULL);
 
   // Should have at least 2 entries. Separator, suggestion.
   EXPECT_LT(2U, menu()->GetMenuSize());
   menu()->GetMenuItem(0, &item);
   EXPECT_EQ(-1, item.command_id);
   menu()->GetMenuItem(1, &item);
   EXPECT_EQ(IDC_CONTENT_CONTEXT_SPELLING_SUGGESTION, item.command_id);
 }