Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 135733006: GN: Add wexit_time_destructors config. (Closed)

Created:
6 years, 11 months ago by bbudge
Modified:
6 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews, cbentzel+watch_chromium.org, erikwright+watch_chromium.org
Visibility:
Public.

Description

GN: Add wexit_time_destructors config. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245034

Patch Set 1 #

Patch Set 2 : Add Brett's comment for config. #

Patch Set 3 : Put new config in a more logical place. #

Total comments: 4

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -9 lines) Patch
M base/BUILD.gn View 2 chunks +2 lines, -4 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 2 3 4 chunks +12 lines, -2 lines 0 comments Download
M tools/gn/secondary/net/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bbudge
I decided to break this out into a separate CL.
6 years, 11 months ago (2014-01-15 00:53:45 UTC) #1
brettw
lgtm https://codereview.chromium.org/135733006/diff/60001/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): https://codereview.chromium.org/135733006/diff/60001/build/config/compiler/BUILD.gn#newcode584 build/config/compiler/BUILD.gn:584: # destructors, which will slow down closing the ...
6 years, 11 months ago (2014-01-15 05:00:16 UTC) #2
bbudge
https://codereview.chromium.org/135733006/diff/60001/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): https://codereview.chromium.org/135733006/diff/60001/build/config/compiler/BUILD.gn#newcode584 build/config/compiler/BUILD.gn:584: # destructors, which will slow down closing the program." ...
6 years, 11 months ago (2014-01-15 13:16:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/135733006/100001
6 years, 11 months ago (2014-01-15 14:03:54 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 00:24:15 UTC) #5
Message was sent while issue was closed. 
Change committed as 245034

Powered by Google App Engine
This is Rietveld 408576698