Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6186)

Unified Diff: build/config/compiler/BUILD.gn

Issue 135733006: GN: Add wexit_time_destructors config. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/BUILD.gn ('k') | tools/gn/secondary/net/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index cc95d62fee6ad76d2799a67e837c52ed3f262916..22e04aeb992df57ce03569e2c6ffdabd677022f0 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -11,7 +11,7 @@ if (cpu_arch == "arm") {
# compiler ---------------------------------------------------------------------
#
# Base compiler configuration.
-#
+#
# See also "runtime_library" below for related stuff and a discusison about
# where stuff should go. Put warning related stuff in the "warnings" config.
@@ -469,7 +469,7 @@ config("no_rtti") {
# Warnings ---------------------------------------------------------------------
#
# This is where we disable various warnings that we've decided aren't
-# worthwhile.
+# worthwhile, and enable special warnings.
config("default_warnings") {
if (is_win) {
@@ -580,6 +580,15 @@ config("default_warnings") {
}
}
+# This will generate warnings when using Clang if code generates exit-time
+# destructors, which will slow down closing the program.
+# TODO(thakis): Make this a blacklist instead, http://crbug.com/101600
+config("wexit_time_destructors") {
+ if (is_clang) {
+ cflags = [ "-Wexit-time-destructors" ]
+ }
+}
+
# Optimization -----------------------------------------------------------------
config("optimize") {
@@ -641,3 +650,4 @@ config("no_symbols") {
cflags = [ "-g0" ]
}
}
+
« no previous file with comments | « base/BUILD.gn ('k') | tools/gn/secondary/net/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698