GN: Add wexit_time_destructors config.

build/config/compiler/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/config.gni")
 import("//build/config/sysroot.gni")
 if (cpu_arch == "arm") {
   import("//build/config/arm.gni")
 }
 
 # compiler ---------------------------------------------------------------------
 #
 # Base compiler configuration.
-# 
+#
 # See also "runtime_library" below for related stuff and a discusison about
 # where stuff should go. Put warning related stuff in the "warnings" config.
 
 config("compiler") {
   cflags = []
   cflags_c = []
   cflags_cc = []
   ldflags = []
   defines = []
   include_dirs = []
@@ skipping 437 matching lines @@
   if (is_win) {
     cflags_cc = [ "/GR-" ]
   } else {
     cflags_cc = [ "-fno-rtti" ]
   }
 }
 
 # Warnings ---------------------------------------------------------------------
 #
 # This is where we disable various warnings that we've decided aren't
-# worthwhile.
+# worthwhile, and enable special warnings.
 
 config("default_warnings") {
   if (is_win) {
     # Please keep ordered and add names if you add more.
     cflags = [
       "/wd4018",  # Comparing signed and unsigned values.
       "/wd4100",  # Unreferenced formal function parameter.
       "/wd4121",  # Alignment of a member was sensitive to packing.
       "/wd4125",  # Decimal digit terminates octal escape sequence.
       "/wd4127",  # Conditional expression is constant.
@@ skipping 90 matching lines @@
         # TODO(torne): Fix this in WebKit.
         "-Wno-error=c++0x-compat",
         # Other things unrelated to -Wextra:
         "-Wno-non-virtual-dtor",
         "-Wno-sign-promo",
       ]
     }
   }
 }
 
+# This will generate warnings when using Clang if code generates exit-time
+# destructors, which will slow down closing the program."

[brettw, 2014/01/15 05:00:16]

Extra "

[bbudge, 2014/01/15 13:16:49]

Done.

+# TODO(thakis): Make this a blacklist instead, http://crbug.com/101600
+config("wexit_time_destructors") {
+  if (is_clang) {
+    cflags = [ "-Wexit-time-destructors" ]
+    #'xcode_settings': {

[brettw, 2014/01/15 05:00:16]

You don't need this.

[bbudge, 2014/01/15 13:16:49]

Done.

+    #  'WARNING_CFLAGS': [
+    #    '-Wexit-time-destructors',
+    #  ],
+    #},
+  }
+}
+
 # Optimization -----------------------------------------------------------------
 
 config("optimize") {
   if (is_win) {
     cflags = [
       "/O2",
       "/Ob2",  # Both explicit and auto inlining.
       "/Oy-",  # Disable omitting frame pointers, must be after /O2.
     ]
   } else {
@@ skipping 41 matching lines @@
   } else {
     cflags = [ "-g1" ]
   }
 }
 
 config("no_symbols") {
   if (!is_win) {
     cflags = [ "-g0" ]
   }
 }
+