Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 1356613002: Reland "[test] Fix cctest path separators on Windows" (Closed)

Created:
5 years, 3 months ago by Jakob Kummerow
Modified:
5 years, 3 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "[test] Fix cctest path separators on Windows" Now run-tests.py understands "suite/foo/bar" with forward slashes for command-line test selection on all test suites on all platforms. Previously, file-based suites like mjsunit also accepted "mjsunit/foo\bar"; that behavior is sacrificed here in favor of unification. For the cctest suite, OTOH, it wasn't possible on Windows to select specific tests at all. Original review: https://codereview.chromium.org/1348653003/ This reverts commit 5f44a9105980e7ca3a444c9c4293ee9442a8139f. NOTRY=true Committed: https://crrev.com/9516dccd41e7d60e7ca89375276ccc1eef03c2aa Cr-Commit-Position: refs/heads/master@{#30798}

Patch Set 1 : original patch #

Patch Set 2 : fix mozilla tests #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -12 lines) Patch
M test/intl/testcfg.py View 1 chunk +3 lines, -1 line 0 comments Download
M test/message/testcfg.py View 1 chunk +3 lines, -1 line 0 comments Download
M test/mjsunit/testcfg.py View 1 chunk +3 lines, -1 line 0 comments Download
M test/mozilla/testcfg.py View 1 2 chunks +4 lines, -3 lines 1 comment Download
M test/test262-es6/testcfg.py View 1 chunk +3 lines, -2 lines 0 comments Download
M test/test262/testcfg.py View 1 chunk +3 lines, -2 lines 0 comments Download
M test/webkit/testcfg.py View 1 chunk +3 lines, -1 line 0 comments Download
M tools/testrunner/local/testsuite.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Jakob Kummerow
PTAL.
5 years, 3 months ago (2015-09-17 12:45:26 UTC) #2
Michael Achenbach
lgtm https://codereview.chromium.org/1356613002/diff/20001/test/mozilla/testcfg.py File test/mozilla/testcfg.py (right): https://codereview.chromium.org/1356613002/diff/20001/test/mozilla/testcfg.py#newcode100 test/mozilla/testcfg.py:100: reduce(os.path.join, testfilepath[:i], ""), Fly-by code spottin: reduce(os.path.join, testfilepath[:i], ...
5 years, 3 months ago (2015-09-17 12:49:20 UTC) #3
Michael Achenbach
I added notry, as the original passed CQ and mozilla isn't on it anyways.
5 years, 3 months ago (2015-09-17 12:54:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356613002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356613002/20001
5 years, 3 months ago (2015-09-17 12:59:03 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-17 13:01:04 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 13:01:22 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9516dccd41e7d60e7ca89375276ccc1eef03c2aa
Cr-Commit-Position: refs/heads/master@{#30798}

Powered by Google App Engine
This is Rietveld 408576698