Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: test/mozilla/testcfg.py

Issue 1356613002: Reland "[test] Fix cctest path separators on Windows" (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix mozilla tests Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/mjsunit/testcfg.py ('k') | test/test262-es6/testcfg.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mozilla/testcfg.py
diff --git a/test/mozilla/testcfg.py b/test/mozilla/testcfg.py
index 70a7ac663cde287e87f73808dd1fed2d96f41139..c6bfc1fda8546bc917f8f9851e845d18ab89f6d7 100644
--- a/test/mozilla/testcfg.py
+++ b/test/mozilla/testcfg.py
@@ -81,8 +81,9 @@ class MozillaTestSuite(testsuite.TestSuite):
files.sort()
for filename in files:
if filename.endswith(".js") and not filename in FRAMEWORK:
- testname = os.path.join(dirname[len(self.testroot) + 1:],
- filename[:-3])
+ fullpath = os.path.join(dirname, filename)
+ relpath = fullpath[len(self.testroot) + 1 : -3]
+ testname = relpath.replace(os.path.sep, "/")
case = testcase.TestCase(self, testname)
tests.append(case)
return tests
@@ -93,7 +94,7 @@ class MozillaTestSuite(testsuite.TestSuite):
result += ["--expose-gc"]
result += [os.path.join(self.root, "mozilla-shell-emulation.js")]
testfilename = testcase.path + ".js"
- testfilepath = testfilename.split(os.path.sep)
+ testfilepath = testfilename.split("/")
for i in xrange(len(testfilepath)):
script = os.path.join(self.testroot,
reduce(os.path.join, testfilepath[:i], ""),
Michael Achenbach 2015/09/17 12:49:19 Fly-by code spottin: reduce(os.path.join, testfile
« no previous file with comments | « test/mjsunit/testcfg.py ('k') | test/test262-es6/testcfg.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698