Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(954)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 135653002: Update modules classes to use OVERRIDE / FINAL when needed (Closed)

Created:
6 years, 11 months ago by Inactive
Modified:
6 years, 11 months ago
CC:
blink-reviews, jsbell, philipj_slow, alecflett, timvolodine, Raymond Toy, kinuko, feature-media-reviews_chromium.org, tommyw+watchlist_chromium.org, dgrogan, Inactive, cmumford, Michael van Ouwerkerk
Visibility:
Public.

Description

Update modules classes to use OVERRIDE / FINAL when needed Update modules classes to use OVERRIDE / FINAL when needed. Those are useful for error checking or performance when the compiler supports it. R=eseidel, jochen BUG=333316 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164941

Patch Set 1 #

Patch Set 2 : Remove change to web/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+410 lines, -409 lines) Patch
M Source/modules/crypto/CryptoResultImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/crypto/DOMWindowCrypto.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/crypto/WorkerGlobalScopeCrypto.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/device_orientation/DeviceMotionController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/device_orientation/DeviceMotionDispatcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/device_orientation/DeviceMotionEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/device_orientation/DeviceOrientationController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/device_orientation/DeviceOrientationEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/device_orientation/DeviceSensorEventController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/donottrack/NavigatorDoNotTrack.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encoding/TextDecoder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/encoding/TextEncoder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/encryptedmedia/MediaKeyMessageEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encryptedmedia/MediaKeyNeededEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encryptedmedia/MediaKeySession.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/filesystem/DOMFileSystem.h View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/modules/filesystem/DOMFileSystemSync.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/DOMFileSystemSync.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M Source/modules/filesystem/DirectoryEntry.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/filesystem/DirectoryEntrySync.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/filesystem/FileEntry.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/filesystem/FileEntrySync.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/filesystem/FileSystemCallbacks.h View 7 chunks +16 lines, -16 lines 0 comments Download
M Source/modules/filesystem/FileWriter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/filesystem/FileWriterSync.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/LocalFileSystem.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/SyncCallbackHelper.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/gamepad/NavigatorGamepad.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/geolocation/Geolocation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/geolocation/GeolocationController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/geolocation/NavigatorGeolocation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/imagebitmap/ImageBitmapFactories.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/indexeddb/DOMWindowIndexedDatabase.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBCursorWithValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBDatabase.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/modules/indexeddb/IDBObjectStore.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/indexeddb/IDBOpenDBRequest.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/IDBRequest.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/modules/indexeddb/IDBRequestTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/IDBTransaction.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/indexeddb/IDBTransactionTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/IDBVersionChangeEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/PageGroupIndexedDatabase.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/WebIDBCallbacksImpl.h View 1 chunk +13 lines, -13 lines 0 comments Download
M Source/modules/indexeddb/WebIDBDatabaseCallbacksImpl.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/modules/indexeddb/WorkerGlobalScopeIndexedDatabase.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/MediaSource.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/MediaSourceBase.h View 2 chunks +12 lines, -12 lines 0 comments Download
M Source/modules/mediasource/MediaSourceRegistry.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/SourceBuffer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/SourceBufferList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/WebKitMediaSource.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/WebKitSourceBufferList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/MediaConstraintsImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/MediaStream.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/MediaStreamEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/MediaStreamRegistry.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/MediaStreamTrack.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/MediaStreamTrackEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/RTCDTMFSender.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/RTCDTMFToneChangeEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/RTCDataChannel.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/RTCDataChannelEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/RTCIceCandidateEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/RTCPeerConnection.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/RTCStatsRequestImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/RTCStatsResponse.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/RTCVoidRequestImpl.h View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/modules/mediastream/UserMediaController.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/UserMediaRequest.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/navigatorcontentutils/NavigatorContentUtils.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/notifications/DOMWindowNotifications.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/notifications/Notification.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/notifications/NotificationBase.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/notifications/NotificationCenter.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/notifications/NotificationController.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/notifications/WebKitNotification.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/notifications/WorkerGlobalScopeNotifications.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/performance/SharedWorkerPerformance.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/performance/WorkerGlobalScopePerformance.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/quota/DOMWindowQuota.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/quota/NavigatorStorageQuota.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/quota/StorageErrorCallback.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/quota/WebStorageQuotaCallbacksImpl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/quota/WorkerNavigatorStorageQuota.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/DOMWindowSpeechSynthesis.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechRecognition.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/speech/SpeechRecognitionController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechRecognitionError.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechRecognitionEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechSynthesis.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/speech/SpeechSynthesisEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/speech/SpeechSynthesisUtterance.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/speech/testing/PlatformSpeechSynthesizerMock.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/modules/vibration/NavigatorVibration.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/AnalyserNode.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/webaudio/AudioBasicInspectorNode.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/webaudio/AudioBasicProcessorNode.h View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/modules/webaudio/AudioBufferSourceNode.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/webaudio/AudioContext.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/webaudio/AudioDestinationNode.h View 4 chunks +7 lines, -7 lines 0 comments Download
M Source/modules/webaudio/AudioNode.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/webaudio/AudioNodeInput.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/AudioParam.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/AudioProcessingEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/webaudio/AudioSourceNode.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webaudio/BiquadDSPKernel.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/webaudio/BiquadFilterNode.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/BiquadProcessor.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/webaudio/ChannelMergerNode.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/webaudio/ChannelSplitterNode.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/webaudio/ConvolverNode.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/modules/webaudio/DefaultAudioDestinationNode.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/DelayDSPKernel.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/DelayNode.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/DelayProcessor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webaudio/DynamicsCompressorNode.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/modules/webaudio/GainNode.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/webaudio/MediaElementAudioSourceNode.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/webaudio/MediaStreamAudioDestinationNode.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/webaudio/MediaStreamAudioSourceNode.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/webaudio/OfflineAudioCompletionEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/webaudio/OfflineAudioContext.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/OfflineAudioDestinationNode.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/webaudio/OscillatorNode.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/webaudio/PannerNode.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/modules/webaudio/ScriptProcessorNode.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/modules/webaudio/WaveShaperDSPKernel.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/webaudio/WaveShaperNode.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/WaveShaperProcessor.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/webdatabase/ChangeVersionWrapper.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/modules/webdatabase/Database.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/webdatabase/Database.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/modules/webdatabase/DatabaseBackend.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/DatabaseBackendSync.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseContext.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/webdatabase/DatabaseManager.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/DatabaseServer.h View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/modules/webdatabase/DatabaseSync.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/DatabaseTask.h View 7 chunks +14 lines, -14 lines 0 comments Download
M Source/modules/webdatabase/DatabaseTracker.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/modules/webdatabase/SQLStatement.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/webdatabase/SQLStatementBackend.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/webdatabase/SQLTransaction.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/SQLTransactionBackend.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/SQLTransactionSync.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/MIDIAccess.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/webmidi/MIDIAccessPromise.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/MIDIAccessor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/MIDIClientMock.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/MIDIConnectionEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/MIDIController.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webmidi/MIDIInput.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/MIDIMessageEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/MIDIOutput.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/MIDIPort.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/NavigatorWebMIDI.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/CloseEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/MainThreadWebSocketChannel.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/modules/websockets/NewWebSocketChannelImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/NewWebSocketChannelImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/WebSocket.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/websockets/WebSocketDeflateFramer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/WebSocketExtensionDispatcherTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/WebSocketPerMessageDeflate.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/WorkerThreadableWebSocketChannel.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/websockets/WorkerThreadableWebSocketChannel.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
6 years, 11 months ago (2014-01-11 20:19:59 UTC) #1
eseidel
lgtm
6 years, 11 months ago (2014-01-12 03:23:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/135653002/70001
6 years, 11 months ago (2014-01-12 03:23:29 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-13 00:48:58 UTC) #4
Message was sent while issue was closed. 
Change committed as 164941

Powered by Google App Engine
This is Rietveld 408576698