components/gcm_driver/gcm_account_tracker_unittest.cc - Issue 1355983002: Cleanup: Pass std::string as const reference from components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/gcm_account_tracker_unittest.cc

Issue 1355983002: Cleanup: Pass std::string as const reference from components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert to PS2 Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/dom_distiller/core/url_utils_unittest.cc ('k') | components/invalidation/impl/gcm_network_channel_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/gcm_driver/gcm_account_tracker_unittest.cc

diff --git a/components/gcm_driver/gcm_account_tracker_unittest.cc b/components/gcm_driver/gcm_account_tracker_unittest.cc

index 38d15328929ae3d4925158f0097ea0d90bd7301b..292996d835ccd858d7ce3989f12eeb837d32e1ed 100644

--- a/components/gcm_driver/gcm_account_tracker_unittest.cc

+++ b/components/gcm_driver/gcm_account_tracker_unittest.cc

@@ -24,11 +24,11 @@ namespace {

const char kAccountId1[] = "account_1";

const char kAccountId2[] = "account_2";

-std::string AccountKeyToObfuscatedId(const std::string email) {

+std::string AccountKeyToObfuscatedId(const std::string& email) {

return "obfid-" + email;

}

-std::string GetValidTokenInfoResponse(const std::string account_key) {

+std::string GetValidTokenInfoResponse(const std::string& account_key) {

return std::string("{ \"id\": \"") + AccountKeyToObfuscatedId(account_key) +

"\" }";

}