components/dom_distiller/core/url_utils_unittest.cc - Issue 1355983002: Cleanup: Pass std::string as const reference from components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/dom_distiller/core/url_utils_unittest.cc

Issue 1355983002: Cleanup: Pass std::string as const reference from components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert to PS2 Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/dom_distiller/core/dom_distiller_store_unittest.cc ('k') | components/gcm_driver/gcm_account_tracker_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/dom_distiller/core/url_utils_unittest.cc

diff --git a/components/dom_distiller/core/url_utils_unittest.cc b/components/dom_distiller/core/url_utils_unittest.cc

index 92059fd36a87232682964befe2cdf589ade854ff..5572a0c1ae35af71d87d873ab817b4d104ee17ec 100644

--- a/components/dom_distiller/core/url_utils_unittest.cc

+++ b/components/dom_distiller/core/url_utils_unittest.cc

@@ -41,12 +41,12 @@ TEST(DomDistillerUrlUtilsTest, TestGetValueForKeyInUrlPathQuery) {

EXPECT_EQ("foo", GetValueForKeyInUrlPathQuery(valid_url_two_keys, "key"));

}

-std::string ThroughDistiller(std::string url) {

+std::string ThroughDistiller(const std::string& url) {

return GetOriginalUrlFromDistillerUrl(

GetDistillerViewUrlFromUrl(kDomDistillerScheme, GURL(url))).spec();

}

-std::string GetOriginalUrlFromDistillerUrl(std::string url) {

+std::string GetOriginalUrlFromDistillerUrl(const std::string& url) {

return GetOriginalUrlFromDistillerUrl(GURL(url)).spec();

}