components/invalidation/impl/gcm_network_channel_unittest.cc - Issue 1355983002: Cleanup: Pass std::string as const reference from components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/invalidation/impl/gcm_network_channel_unittest.cc

Issue 1355983002: Cleanup: Pass std::string as const reference from components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert to PS2 Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/invalidation/impl/gcm_network_channel_unittest.cc

diff --git a/components/invalidation/impl/gcm_network_channel_unittest.cc b/components/invalidation/impl/gcm_network_channel_unittest.cc

index e07788e5e0d5d88a35f7ec9795d791b60b252899..e0597f8eebbd5a3682476cffa2fe52e4c5bbd411 100644

--- a/components/invalidation/impl/gcm_network_channel_unittest.cc

+++ b/components/invalidation/impl/gcm_network_channel_unittest.cc

@@ -170,8 +170,7 @@ class GCMNetworkChannelTest

last_invalidator_state_ = invalidator_state;

}

- void OnIncomingMessage(std::string incoming_message) {

- }

+ void OnIncomingMessage(std::string /* incoming_message */) {}

GCMNetworkChannel* network_channel() {

return gcm_network_channel_.get();

« no previous file with comments | « components/gcm_driver/gcm_account_tracker_unittest.cc ('k') | components/metrics/cloned_install_detector.h » ('j') | no next file with comments »