[refactor] Misc post-NSS WebCrypto cleanups.

[refactor] Misc post-NSS WebCrypto cleanups.

  * Use EVP_MD_block_size() rather than a custom switch statement
  * Update language explaining why 192-bit AES is disallowed
  * Remove remaining SupportsXXX() functions from unittests.

Committed: https://crrev.com/f5d6b2afc9673e55ceac6a3b7d576358081b2dc7
Cr-Commit-Position: refs/heads/master@{#350283}

[eroman, 2015-09-18 23:47:49]

eroman@chromium.org changed reviewers:
+ davidben@chromium.org

[davidben, 2015-09-22 19:08:25]

lgtm

https://codereview.chromium.org/1355923002/diff/20001/components/webcrypto/al...
File components/webcrypto/algorithms/aes.cc (right):

https://codereview.chromium.org/1355923002/diff/20001/components/webcrypto/al...
components/webcrypto/algorithms/aes.cc:59: // 192-bit AES is intentionally
unsupported (http://crubg.com/533699)
Nit: period at end.
Also crubg -> crbug

(Ditto below)

https://codereview.chromium.org/1355923002/diff/20001/components/webcrypto/al...
File components/webcrypto/algorithms/aes_cbc.cc (right):

https://codereview.chromium.org/1355923002/diff/20001/components/webcrypto/al...
components/webcrypto/algorithms/aes_cbc.cc:26: // 192-bit AES is intentionally
unsupported (http://crubg.com/533699)
ditto

https://codereview.chromium.org/1355923002/diff/20001/components/webcrypto/al...
File components/webcrypto/algorithms/aes_cbc_unittest.cc (right):

https://codereview.chromium.org/1355923002/diff/20001/components/webcrypto/al...
components/webcrypto/algorithms/aes_cbc_unittest.cc:397: // 192-bit AES is
intentionally unsupported (http://crubg.com/533699)
ditto

https://codereview.chromium.org/1355923002/diff/20001/components/webcrypto/al...
components/webcrypto/algorithms/aes_cbc_unittest.cc:405: // 192-bit AES is
intentionally unsupported (http://crubg.com/533699)
ditto

https://codereview.chromium.org/1355923002/diff/20001/components/webcrypto/al...
File components/webcrypto/algorithms/aes_ctr.cc (right):

https://codereview.chromium.org/1355923002/diff/20001/components/webcrypto/al...
components/webcrypto/algorithms/aes_ctr.cc:27: // 192-bit AES is intentionally
unsupported (http://crubg.com/533699)
ditto

https://codereview.chromium.org/1355923002/diff/20001/components/webcrypto/st...
File components/webcrypto/status.h (right):

https://codereview.chromium.org/1355923002/diff/20001/components/webcrypto/st...
components/webcrypto/status.h:137: // 192-bit AES keys are valid, however
unsupported (http://crbug.com/533699)
Nit: period

[eroman, 2015-09-22 22:25:38]

https://codereview.chromium.org/1355923002/diff/20001/components/webcrypto/al...
File components/webcrypto/algorithms/aes.cc (right):

https://codereview.chromium.org/1355923002/diff/20001/components/webcrypto/al...
components/webcrypto/algorithms/aes.cc:59: // 192-bit AES is intentionally
unsupported (http://crubg.com/533699)
On 2015/09/22 19:08:24, David Benjamin wrote:
> Nit: period at end.
> Also crubg -> crbug
> 
> (Ditto below)

Done (everywhere)

[eroman, 2015-09-22 22:25:54]

The CQ bit was checked by eroman@chromium.org

[eroman, 2015-09-22 22:25:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
davidben@chromium.org
Link to the patchset: https://codereview.chromium.org/1355923002/#ps60001
(title: "crubg.com --> crbug.com")

[commit-bot: I haz the power, 2015-09-22 22:26:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1355923002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1355923002/60001

[commit-bot: I haz the power, 2015-09-22 23:10:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-22 23:10:15]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[eroman, 2015-09-22 23:11:21]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2015-09-22 23:12:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1355923002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1355923002/60001

[eroman, 2015-09-22 23:57:36]

The CQ bit was unchecked by eroman@chromium.org

[commit-bot: I haz the power, 2015-09-22 23:57:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-22 23:57:53]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[eroman, 2015-09-23 00:01:01]

The CQ bit was checked by eroman@chromium.org

[eroman, 2015-09-23 00:01:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
davidben@chromium.org
Link to the patchset: https://codereview.chromium.org/1355923002/#ps80001
(title: "add an explicit size_t --> unsigned cast")

[commit-bot: I haz the power, 2015-09-23 00:03:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1355923002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1355923002/80001

[commit-bot: I haz the power, 2015-09-23 01:05:56]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-09-23 01:08:19]

Patchset 5 (id:??) landed as
https://crrev.com/f5d6b2afc9673e55ceac6a3b7d576358081b2dc7
Cr-Commit-Position: refs/heads/master@{#350283}