[refactor] Misc post-NSS WebCrypto cleanups.

components/webcrypto/algorithms/aes_cbc_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/stl_util.h"
 #include "components/webcrypto/algorithm_dispatch.h"
 #include "components/webcrypto/algorithms/test_helpers.h"
 #include "components/webcrypto/crypto_data.h"
 #include "components/webcrypto/status.h"
 #include "components/webcrypto/webcrypto_util.h"
@@ skipping 376 matching lines @@
                               "A256CBC");
 
   // Large usage value
   ImportExportJwkSymmetricKey(
       256, algorithm,
       blink::WebCryptoKeyUsageEncrypt | blink::WebCryptoKeyUsageDecrypt |
           blink::WebCryptoKeyUsageWrapKey | blink::WebCryptoKeyUsageUnwrapKey,
       "A256CBC");
 }
 
-// AES 192-bit is not allowed: http://crbug.com/381829
+// 192-bit AES is intentionally unsupported (http://crubg.com/533699)

[davidben, 2015/09/22 19:08:24]

ditto

 TEST_F(WebCryptoAesCbcTest, GenerateAesCbc192) {
   blink::WebCryptoKey key;
   Status status = GenerateSecretKey(CreateAesCbcKeyGenAlgorithm(192), true,
                                     blink::WebCryptoKeyUsageEncrypt, &key);
   ASSERT_EQ(Status::ErrorAes192BitUnsupported(), status);
 }
 
-// AES 192-bit is not allowed: http://crbug.com/381829
+// 192-bit AES is intentionally unsupported (http://crubg.com/533699)

[davidben, 2015/09/22 19:08:24]

ditto

 TEST_F(WebCryptoAesCbcTest, UnwrapAesCbc192) {
   std::vector<uint8_t> wrapping_key_data(16, 0);
   std::vector<uint8_t> wrapped_key = HexStringToBytes(
       "1A07ACAB6C906E50883173C29441DB1DE91D34F45C435B5F99C822867FB3956F");
 
   blink::WebCryptoKey wrapping_key = ImportSecretKeyFromRaw(
       wrapping_key_data, CreateAlgorithm(blink::WebCryptoAlgorithmIdAesKw),
       blink::WebCryptoKeyUsageUnwrapKey);
 
   blink::WebCryptoKey unwrapped_key;
@@ skipping 143 matching lines @@
   EXPECT_EQ(public_key_spki, unwrapped_public_key_spki);
   EXPECT_EQ(private_key_pkcs8, unwrapped_private_key_pkcs8);
 
   EXPECT_NE(public_key_spki, wrapped_public_key);
   EXPECT_NE(private_key_pkcs8, wrapped_private_key);
 }
 
 }  // namespace
 
 }  // namespace webcrypto