[refactor] Misc post-NSS WebCrypto cleanups.

components/webcrypto/algorithms/aes.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/webcrypto/algorithms/aes.h"
 
 #include "base/logging.h"
 #include "components/webcrypto/algorithms/secret_key_util.h"
 #include "components/webcrypto/crypto_data.h"
 #include "components/webcrypto/jwk.h"
@@ skipping 38 matching lines @@
 Status AesAlgorithm::GenerateKey(const blink::WebCryptoAlgorithm& algorithm,
                                  bool extractable,
                                  blink::WebCryptoKeyUsageMask usages,
                                  GenerateKeyResult* result) const {
   Status status = CheckKeyCreationUsages(all_key_usages_, usages, false);
   if (status.IsError())
     return status;
 
   unsigned int keylen_bits = algorithm.aesKeyGenParams()->lengthBits();
 
-  // BoringSSL does not support 192-bit AES.
+  // 192-bit AES is intentionally unsupported (http://crubg.com/533699)

[davidben, 2015/09/22 19:08:24]

Nit: period at end.
Also crubg -> crbug

(Ditto below)

[eroman, 2015/09/22 22:25:38]

Done (everywhere)

   if (keylen_bits == 192)
     return Status::ErrorAes192BitUnsupported();
 
   if (keylen_bits != 128 && keylen_bits != 256)
     return Status::ErrorGenerateAesKeyLength();
 
   return GenerateWebCryptoSecretKey(
       blink::WebCryptoKeyAlgorithm::createAes(algorithm.id(), keylen_bits),
       extractable, usages, keylen_bits, result);
 }
@@ skipping 10 matching lines @@
   }
 }
 
 Status AesAlgorithm::ImportKeyRaw(const CryptoData& key_data,
                                   const blink::WebCryptoAlgorithm& algorithm,
                                   bool extractable,
                                   blink::WebCryptoKeyUsageMask usages,
                                   blink::WebCryptoKey* key) const {
   const unsigned int keylen_bytes = key_data.byte_length();
 
-  // BoringSSL does not support 192-bit AES.
+  // 192-bit AES is intentionally unsupported (http://crubg.com/533699)
   if (keylen_bytes == 24)
     return Status::ErrorAes192BitUnsupported();
 
   if (keylen_bytes != 16 && keylen_bytes != 32)
     return Status::ErrorImportAesKeyLength();
 
   // No possibility of overflow.
   unsigned int keylen_bits = keylen_bytes * 8;
 
   return CreateWebCryptoSecretKey(
@@ skipping 70 matching lines @@
 Status AesAlgorithm::GetKeyLength(
     const blink::WebCryptoAlgorithm& key_length_algorithm,
     bool* has_length_bits,
     unsigned int* length_bits) const {
   *has_length_bits = true;
   *length_bits = key_length_algorithm.aesDerivedKeyParams()->lengthBits();
 
   if (*length_bits == 128 || *length_bits == 256)
     return Status::Success();
 
-  // BoringSSL does not support 192-bit AES.
+  // 192-bit AES is intentionally unsupported (http://crubg.com/533699)
   if (*length_bits == 192)
     return Status::ErrorAes192BitUnsupported();
 
   return Status::ErrorGetAesKeyLength();
 }
 
 }  // namespace webcrypto