Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(286)

Issue 1355423003: Devtools: initialize protocol enums synchronously (Closed)

Created:
2 years, 2 months ago by sergeyv
Modified:
2 years, 2 months ago
Reviewers:
dgozman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Devtools: initialize protocol enums synchronously BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202661

Patch Set 1 #

Patch Set 2 : removed WebInspector._connectionForTests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -44 lines) Patch
M LayoutTests/http/tests/inspector/inspector-test.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/inspector/elements/styles-1/cached-sync-computed-styles.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/profiler/heap-snapshot-loader.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/report-API-errors.html View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/main/Main.js View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/main/TestController.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/devtools/front_end/main/module.json View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/devtools/front_end/sdk/InspectorBackend.js View 4 chunks +6 lines, -36 lines 0 comments Download
M Source/devtools/scripts/generate_protocol_externs.py View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
sergeyv
2 years, 2 months ago (2015-09-22 22:36:08 UTC) #2
dgozman
lgtm
2 years, 2 months ago (2015-09-22 23:13:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1355423003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1355423003/20001
2 years, 2 months ago (2015-09-22 23:13:57 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/72406)
2 years, 2 months ago (2015-09-23 03:35:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1355423003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1355423003/20001
2 years, 2 months ago (2015-09-23 03:42:55 UTC) #9
commit-bot: I haz the power
2 years, 2 months ago (2015-09-23 05:04:49 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202661

Powered by Google App Engine
This is Rietveld 0eb02b776