Source/devtools/scripts/generate_protocol_externs.py - Issue 1355423003: Devtools: initialize protocol enums synchronously

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/scripts/generate_protocol_externs.py

Issue 1355423003: Devtools: initialize protocol enums synchronously (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: removed WebInspector._connectionForTests Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/devtools/scripts/generate_protocol_externs.py

diff --git a/Source/devtools/scripts/generate_protocol_externs.py b/Source/devtools/scripts/generate_protocol_externs.py

index 8fe30e42557e8c30204317dbe5c3895f7870c400..1cf87c1fe65b79215c0a11efbf058e05b1e58176 100755

--- a/Source/devtools/scripts/generate_protocol_externs.py

+++ b/Source/devtools/scripts/generate_protocol_externs.py

@@ -160,7 +160,7 @@ Protocol.Error;

output_file.write("/** @param {function(%s):void=} opt_callback */\n" % ", ".join(returns))

output_file.write("Protocol.%sAgent.prototype.invoke_%s = function(obj, opt_callback) {}\n" % (domain_name, command["name"]))

- output_file.write("\n\n\nvar %sAgent = {};\n" % domain_name)

+ output_file.write("\n\n\nvar %sAgent = function(){};\n" % domain_name)

if "types" in domain:

for type in domain["types"]:

« no previous file with comments | « Source/devtools/front_end/sdk/InspectorBackend.js ('k') | no next file » | no next file with comments »