Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1343293005: Devtools: Fix frontend part of LayoutEditor (Closed)

Created:
5 years, 3 months ago by sergeyv
Modified:
5 years, 3 months ago
Reviewers:
dgozman
CC:
blink-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Devtools: Fix frontend part of LayoutEditor BUG=501896

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Total comments: 2

Patch Set 3 : Address a comment #

Patch Set 4 : Reupload after merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -54 lines) Patch
M third_party/WebKit/Source/devtools/front_end/components/InspectElementModeController.js View 1 2 3 5 chunks +75 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js View 1 2 3 2 chunks +0 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/module.json View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
sergeyv
5 years, 3 months ago (2015-09-22 00:32:04 UTC) #2
dgozman
https://codereview.chromium.org/1343293005/diff/1/Source/devtools/front_end/elements/ElementsPanel.js File Source/devtools/front_end/elements/ElementsPanel.js (right): https://codereview.chromium.org/1343293005/diff/1/Source/devtools/front_end/elements/ElementsPanel.js#newcode1333 Source/devtools/front_end/elements/ElementsPanel.js:1333: WebInspector.ElementsPanel.LayoutEditorButtonProvider = function() Let's place this to InspectElementModeController instead. ...
5 years, 3 months ago (2015-09-22 03:13:18 UTC) #3
sergeyv
https://codereview.chromium.org/1343293005/diff/1/Source/devtools/front_end/elements/ElementsPanel.js File Source/devtools/front_end/elements/ElementsPanel.js (right): https://codereview.chromium.org/1343293005/diff/1/Source/devtools/front_end/elements/ElementsPanel.js#newcode1333 Source/devtools/front_end/elements/ElementsPanel.js:1333: WebInspector.ElementsPanel.LayoutEditorButtonProvider = function() On 2015/09/22 03:13:18, dgozman wrote: > ...
5 years, 3 months ago (2015-09-22 23:18:55 UTC) #5
dgozman
lgtm https://codereview.chromium.org/1343293005/diff/40001/Source/devtools/front_end/components/InspectElementModeController.js File Source/devtools/front_end/components/InspectElementModeController.js (right): https://codereview.chromium.org/1343293005/diff/40001/Source/devtools/front_end/components/InspectElementModeController.js#newcode108 Source/devtools/front_end/components/InspectElementModeController.js:108: var mode; if suspended return
5 years, 3 months ago (2015-09-22 23:46:56 UTC) #6
sergeyv
https://codereview.chromium.org/1343293005/diff/40001/Source/devtools/front_end/components/InspectElementModeController.js File Source/devtools/front_end/components/InspectElementModeController.js (right): https://codereview.chromium.org/1343293005/diff/40001/Source/devtools/front_end/components/InspectElementModeController.js#newcode108 Source/devtools/front_end/components/InspectElementModeController.js:108: var mode; On 2015/09/22 23:46:56, dgozman wrote: > if ...
5 years, 3 months ago (2015-09-22 23:52:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343293005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343293005/60001
5 years, 3 months ago (2015-09-23 05:39:27 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 18:01:07 UTC) #12 
Failed to commit the patch.
Sending        Source/core/inspector/InspectorOverlayPage.html
Sending       
Source/devtools/front_end/components/InspectElementModeController.js
Sending        Source/devtools/front_end/elements/ElementsPanel.js
Sending        Source/devtools/front_end/elements/StylesSidebarPane.js
Sending        Source/devtools/front_end/main/module.json
Transmitting file data .....svn: E165001: Commit failed (details follow):
svn: E165001: Commit blocked by pre-commit hook (exit code 2) with output:
Sorry, /trunk/ is locked in read-only mode.

Powered by Google App Engine
This is Rietveld 408576698