Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1371483003: cvox2: Avoid uncaught exception on invalid input type. (Closed)

Created:
5 years, 3 months ago by Peter Lundblad
Modified:
5 years, 2 months ago
Reviewers:
dmazzoni, David Tseng
CC:
chromium-reviews, extensions-reviews_chromium.org, dtseng+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cvox2: Avoid uncaught exception on invalid input type. <input type='invalidType'> would cause an uncaught exception in the output code. Whitelist supported types and default invalid types to 'text'. NOTE: The mappings in the whitelist currently look a bit pointless. A follow-up cl to clean up duplicated messages will make this more useful, however. BUG=None R=dtseng@chromium.org Committed: https://crrev.com/54b0ed7b668c16b11aedf0858c8e3619d0587f91 Cr-Commit-Position: refs/heads/master@{#350819}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix typo #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -5 lines) Patch
M chrome/browser/resources/chromeos/chromevox/common/chrome_extension_externs.js View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 3 chunks +26 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs View 1 5 chunks +9 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
Peter Lundblad
5 years, 3 months ago (2015-09-24 21:29:07 UTC) #1
dmazzoni
lgtm https://codereview.chromium.org/1371483003/diff/1/chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs File chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs (right): https://codereview.chromium.org/1371483003/diff/1/chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs#newcode247 chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs:247: '<input type="invalidType"</input', nit: missing closing angle bracket
5 years, 3 months ago (2015-09-24 22:12:46 UTC) #3
Peter Lundblad
dmazzoni@chromium.org writes: > lgtm > > > > > https://codereview.chromium.org/1371483003/diff/1/chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs > File > chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs > ...
5 years, 3 months ago (2015-09-25 08:19:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371483003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371483003/40001
5 years, 2 months ago (2015-09-25 13:16:40 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-09-25 14:08:58 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 14:09:56 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/54b0ed7b668c16b11aedf0858c8e3619d0587f91
Cr-Commit-Position: refs/heads/master@{#350819}

Powered by Google App Engine
This is Rietveld 408576698