Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 1354063002: Reland debugging for ipc related crash. (Closed)

Created:
5 years, 3 months ago by erikchen
Modified:
5 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland debugging for ipc related crash. This CL is almost identical to https://codereview.chromium.org/1350823002/. The only difference is that the part of the CL that causes the crash has been omitted. BUG=527588 Committed: https://crrev.com/a7502c6dff276bce3c76d680c5d613cb6ece19be Cr-Commit-Position: refs/heads/master@{#349828}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -2 lines) Patch
M content/browser/browser_main_loop.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M content/browser/loader/async_resource_handler.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/child/child_thread_impl.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M content/child/resource_dispatcher.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M content/child/resource_scheduling_filter.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/child/threaded_data_provider.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/common/resource_messages.h View 1 chunk +6 lines, -0 lines 0 comments Download
M content/common/resource_messages.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M ipc/ipc_channel.h View 1 chunk +5 lines, -0 lines 0 comments Download
M ipc/ipc_channel_common.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M ipc/ipc_channel_reader.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M ipc/ipc_channel_win.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M ipc/ipc_message.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (2 generated)
erikchen
avi, tsepez: Please review.
5 years, 3 months ago (2015-09-18 00:51:55 UTC) #2
Avi (use Gerrit)
still lgtm
5 years, 3 months ago (2015-09-18 01:51:09 UTC) #3
Tom Sepez
lgtm
5 years, 3 months ago (2015-09-18 22:42:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1354063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1354063002/1
5 years, 3 months ago (2015-09-18 23:23:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-19 00:55:14 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a7502c6dff276bce3c76d680c5d613cb6ece19be Cr-Commit-Position: refs/heads/master@{#349828}
5 years, 3 months ago (2015-09-19 00:55:54 UTC) #8
erikchen
5 years, 3 months ago (2015-09-21 23:37:11 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1354863004/ by erikchen@chromium.org.

The reason for reverting is: Supposedly, this CL only changes the signature of
the crash, not the presence of the crash. There is some (but not totally clear)
evidence that this CL is causing a crash itself.

https://code.google.com/p/chromium/issues/detail?id=527588#c32.

Powered by Google App Engine
This is Rietveld 408576698