Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1346923008: Add a dummy variable to ResourceMsg_DataReceived. (Closed)

Created:
5 years, 3 months ago by erikchen
Modified:
5 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@ipc_revert2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content: Add a dummy variable to ResourceMsg_DataReceived. I suspect that this will expose a crash for a small number of Windows canary users. This CL is only intended to be landed for one day. BUG=527588 Committed: https://crrev.com/a59c6e37a4cc9f01ab0a8fffc79004875a8b0617 Cr-Commit-Position: refs/heads/master@{#349830}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Fix unit test error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -8 lines) Patch
M content/browser/loader/async_resource_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_unittest.cc View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M content/child/resource_dispatcher.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/child/resource_dispatcher.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/child/resource_dispatcher_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/threaded_data_provider.cc View 1 3 chunks +9 lines, -3 lines 0 comments Download
M content/common/resource_messages.h View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M content/common/resource_messages.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1354063002 Patch 1

Messages

Total messages: 26 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346923008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346923008/1
5 years, 3 months ago (2015-09-18 01:01:55 UTC) #2
erikchen
avi: Please review. See https://code.google.com/p/chromium/issues/detail?id=527588#c25 for an explanation for this CL.
5 years, 3 months ago (2015-09-18 01:18:31 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346923008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346923008/20001
5 years, 3 months ago (2015-09-18 01:25:26 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346923008/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346923008/40001
5 years, 3 months ago (2015-09-18 01:29:08 UTC) #9
Avi (use Gerrit)
lgtm Oh dear. Good luck.
5 years, 3 months ago (2015-09-18 01:50:17 UTC) #10
Avi (use Gerrit)
On 2015/09/18 01:50:17, Avi wrote: > lgtm > > Oh dear. Good luck. You'll need ...
5 years, 3 months ago (2015-09-18 01:50:38 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/56229)
5 years, 3 months ago (2015-09-18 02:22:08 UTC) #13
erikchen
tsepez: Looking for a review of content/common/resource_messages.*
5 years, 3 months ago (2015-09-18 16:30:47 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346923008/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346923008/60001
5 years, 3 months ago (2015-09-18 16:30:49 UTC) #17
Tom Sepez
lgtm
5 years, 3 months ago (2015-09-18 16:58:20 UTC) #18
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-18 17:57:26 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346923008/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346923008/60001
5 years, 3 months ago (2015-09-19 01:03:05 UTC) #23
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-09-19 01:07:44 UTC) #24
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/a59c6e37a4cc9f01ab0a8fffc79004875a8b0617 Cr-Commit-Position: refs/heads/master@{#349830}
5 years, 3 months ago (2015-09-19 01:08:25 UTC) #25
erikchen
5 years, 3 months ago (2015-09-20 22:29:09 UTC) #26
Message was sent while issue was closed. 
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1347373003/ by erikchen@chromium.org.

The reason for reverting is: This CL was only intended to be a part of one
canary release..

Powered by Google App Engine
This is Rietveld 408576698