Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Unified Diff: ipc/ipc_message.cc

Issue 1354063002: Reland debugging for ipc related crash. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/ipc_channel_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_message.cc
diff --git a/ipc/ipc_message.cc b/ipc/ipc_message.cc
index 99868a39ef71dbc90c9d30cabd94e79cc41e3daf..f4d508e1abec9128be3d9e6b1cfcf2baeb693009 100644
--- a/ipc/ipc_message.cc
+++ b/ipc/ipc_message.cc
@@ -149,7 +149,7 @@ void Message::FindNext(const char* range_start,
// The data is not copied.
size_t pickle_len = static_cast<size_t>(pickle_end - range_start);
Message message(range_start, static_cast<int>(pickle_len));
- int num_attachments = message.header()->num_brokered_attachments;
+ size_t num_attachments = message.header()->num_brokered_attachments;
// Check for possible overflows.
size_t max_size_t = std::numeric_limits<size_t>::max();
@@ -165,7 +165,7 @@ void Message::FindNext(const char* range_start,
if (buffer_length < attachment_length + pickle_len)
return;
- for (int i = 0; i < num_attachments; ++i) {
+ for (size_t i = 0; i < num_attachments; ++i) {
const char* attachment_start =
pickle_end + i * BrokerableAttachment::kNonceSize;
BrokerableAttachment::AttachmentId id(attachment_start,
« no previous file with comments | « ipc/ipc_channel_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698