Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1306)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 135403009: Rename GestureEventQueue to TouchDispositionGestureFilter (Closed)

Created:
6 years, 10 months ago by jdduke (slow)
Modified:
6 years, 10 months ago
Reviewers:
jam, tdresser
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Rename GestureEventQueue to TouchDispositionGestureFilter The current GestureEventQueue does a good deal more than simply queue gestures. It handles gesture sequence filtering per touch event ack dispositions, and also provides gesture event insertion for various gesture transitions. BUG=340075 TBR=jam@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248529

Patch Set 1 #

Patch Set 2 : Rename #

Patch Set 3 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -834 lines) Patch
M content/browser/android/content_view_core_impl.h View 1 2 4 chunks +6 lines, -5 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 1 5 chunks +6 lines, -5 lines 0 comments Download
D content/browser/renderer_host/input/gesture_event_queue.h View 1 chunk +0 lines, -94 lines 0 comments Download
D content/browser/renderer_host/input/gesture_event_queue.cc View 1 chunk +0 lines, -216 lines 0 comments Download
D content/browser/renderer_host/input/gesture_event_queue_unittest.cc View 1 chunk +0 lines, -449 lines 0 comments Download
A + content/browser/renderer_host/input/touch_disposition_gesture_filter.h View 1 4 chunks +20 lines, -20 lines 0 comments Download
A + content/browser/renderer_host/input/touch_disposition_gesture_filter.cc View 1 8 chunks +29 lines, -21 lines 0 comments Download
A + content/browser/renderer_host/input/touch_disposition_gesture_filter_unittest.cc View 1 14 chunks +22 lines, -20 lines 0 comments Download
M content/content_browser.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
jdduke (slow)
tdresser@: PTAL. Thanks.
6 years, 10 months ago (2014-02-03 16:21:45 UTC) #1
tdresser
LGTM
6 years, 10 months ago (2014-02-03 16:48:29 UTC) #2
jdduke (slow)
jam@: Owner review for content/content_browser.gypi, content/content_tests.gypi? Thanks.
6 years, 10 months ago (2014-02-03 16:52:25 UTC) #3
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 10 months ago (2014-02-03 16:52:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/135403009/130001
6 years, 10 months ago (2014-02-03 16:52:38 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-03 18:22:50 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=255612
6 years, 10 months ago (2014-02-03 18:22:51 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 18:22:53 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 18:22:58 UTC) #9
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 10 months ago (2014-02-03 18:33:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/135403009/130001
6 years, 10 months ago (2014-02-03 18:34:05 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 18:35:38 UTC) #12
commit-bot: I haz the power
Change committed as 248529
6 years, 10 months ago (2014-02-03 18:35:38 UTC) #13
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 18:35:42 UTC) #14
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698