Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Unified Diff: content/browser/renderer_host/input/touch_disposition_gesture_filter.h

Issue 135403009: Rename GestureEventQueue to TouchDispositionGestureFilter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix comment Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/input/touch_disposition_gesture_filter.h
diff --git a/content/browser/renderer_host/input/gesture_event_queue.h b/content/browser/renderer_host/input/touch_disposition_gesture_filter.h
similarity index 67%
rename from content/browser/renderer_host/input/gesture_event_queue.h
rename to content/browser/renderer_host/input/touch_disposition_gesture_filter.h
index 8855453494f884714463a96b278c789eafd25cce..d7d5076368f52c48178e567448804ca37d43246e 100644
--- a/content/browser/renderer_host/input/gesture_event_queue.h
+++ b/content/browser/renderer_host/input/touch_disposition_gesture_filter.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CONTENT_BROWSER_RENDERER_HOST_INPUT_GESTURE_EVENT_QUEUE_H_
-#define CONTENT_BROWSER_RENDERER_HOST_INPUT_GESTURE_EVENT_QUEUE_H_
+#ifndef CONTENT_BROWSER_RENDERER_HOST_INPUT_TOUCH_DISPOSITION_GESTURE_FILTER_H_
+#define CONTENT_BROWSER_RENDERER_HOST_INPUT_TOUCH_DISPOSITION_GESTURE_FILTER_H_
#include <deque>
#include <queue>
@@ -15,26 +15,26 @@
namespace content {
-// Interface with which the |GestureEventQueue| forwards gestures for a given
-// touch event.
-class CONTENT_EXPORT GestureEventQueueClient {
+// Interface with which the |TouchDispositionGestureFilter| forwards gestures
+// for a given touch event.
+class CONTENT_EXPORT TouchDispositionGestureFilterClient {
public:
virtual void ForwardGestureEvent(const blink::WebGestureEvent&) = 0;
};
-// Handles dispatch of touch-derived gestures created by the platform.
-// Gestures are forwarded or dropped depending on the ack dispositions of the
-// generating touch sequence.
-class CONTENT_EXPORT GestureEventQueue {
+// Given a stream of touch-derived gesture packets, produces a refined gesture
+// sequence based on the ack dispositions of the generating touch events.
+class CONTENT_EXPORT TouchDispositionGestureFilter {
public:
- explicit GestureEventQueue(GestureEventQueueClient* client);
- ~GestureEventQueue();
-
- // To be called upon receipt of gesture-related events. In particular,
- // |packet| contains [0, n] gestures that correspond to a given event. That
- // event may be a touch, or a touch timeout for certain stationary gestures.
- // It is imperative that a single packet is received for *each* touch event,
- // even those that did not produce a gesture.
+ explicit TouchDispositionGestureFilter(
+ TouchDispositionGestureFilterClient* client);
+ ~TouchDispositionGestureFilter();
+
+ // To be called upon production of touch-derived gestures by the platform,
+ // *prior* to the generating touch being forward to the renderer. In
+ // particular, |packet| contains [0, n] gestures that correspond to a given
+ // touch event. It is imperative that a single packet is received for
+ // *each* touch event, even those that did not produce a gesture.
void OnGestureEventPacket(const GestureEventPacket& packet);
// To be called upon receipt of *all* touch event acks.
@@ -77,7 +77,7 @@ class CONTENT_EXPORT GestureEventQueue {
GestureSequence& Head();
GestureSequence& Tail();
- GestureEventQueueClient* client_;
+ TouchDispositionGestureFilterClient* client_;
std::queue<GestureSequence> sequences_;
// Bookkeeping for inserting synthetic Gesture{Tap,Fling}Cancel events
@@ -86,9 +86,9 @@ class CONTENT_EXPORT GestureEventQueue {
bool needs_tap_ending_event_;
bool needs_fling_ending_event_;
- DISALLOW_COPY_AND_ASSIGN(GestureEventQueue);
+ DISALLOW_COPY_AND_ASSIGN(TouchDispositionGestureFilter);
};
} // namespace content
-#endif // CONTENT_BROWSER_RENDERER_HOST_INPUT_GESTURE_EVENT_QUEUE_H_
+#endif // CONTENT_BROWSER_RENDERER_HOST_INPUT_TOUCH_DISPOSITION_GESTURE_FILTER_H_

Powered by Google App Engine
This is Rietveld 408576698