Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1353683005: EDK: Convert remaining scoped_ptr -> std::unique_ptr in //mojo/edk/system. (Closed)

Created:
5 years, 3 months ago by viettrungluu
Modified:
5 years, 3 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

EDK: Convert remaining scoped_ptr -> std::unique_ptr in //mojo/edk/system. Now only //mojo/edk/embedder remains. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/266a79f1db23a4a3bbddf09dadc68776ae8c4d56

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -114 lines) Patch
M mojo/edk/system/channel.h View 2 chunks +1 line, -2 lines 0 comments Download
M mojo/edk/system/channel.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M mojo/edk/system/channel_endpoint.h View 4 chunks +6 lines, -5 lines 0 comments Download
M mojo/edk/system/channel_endpoint.cc View 5 chunks +12 lines, -8 lines 0 comments Download
M mojo/edk/system/channel_endpoint_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/edk/system/channel_endpoint_unittest.cc View 5 chunks +8 lines, -4 lines 0 comments Download
M mojo/edk/system/core.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/edk/system/data_pipe_impl.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M mojo/edk/system/dispatcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/edk/system/endpoint_relayer.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M mojo/edk/system/endpoint_relayer_unittest.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M mojo/edk/system/incoming_endpoint.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/local_message_pipe_endpoint.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/local_message_pipe_endpoint.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M mojo/edk/system/master_connection_manager.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M mojo/edk/system/message_in_transit_queue.h View 3 chunks +5 lines, -5 lines 0 comments Download
M mojo/edk/system/message_in_transit_test_utils.h View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/edk/system/message_in_transit_test_utils.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M mojo/edk/system/message_pipe.h View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/edk/system/message_pipe.cc View 6 chunks +8 lines, -6 lines 0 comments Download
M mojo/edk/system/message_pipe_endpoint.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/proxy_message_pipe_endpoint.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/proxy_message_pipe_endpoint.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M mojo/edk/system/raw_channel.h View 3 chunks +2 lines, -3 lines 0 comments Download
M mojo/edk/system/raw_channel.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M mojo/edk/system/raw_channel_posix.cc View 6 chunks +6 lines, -5 lines 0 comments Download
M mojo/edk/system/raw_channel_unittest.cc View 4 chunks +10 lines, -9 lines 0 comments Download
M mojo/edk/system/remote_consumer_data_pipe_impl.cc View 5 chunks +8 lines, -7 lines 0 comments Download
M mojo/edk/system/remote_producer_data_pipe_impl.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M mojo/edk/system/slave_connection_manager.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M mojo/edk/system/test_channel_endpoint_client.h View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/edk/system/test_channel_endpoint_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Issue 1351293002 Patch 1

Messages

Total messages: 3 (0 generated)
viettrungluu
5 years, 3 months ago (2015-09-18 02:38:17 UTC) #1
vardhan
lgtm
5 years, 3 months ago (2015-09-18 07:51:07 UTC) #2
viettrungluu
5 years, 3 months ago (2015-09-18 15:27:52 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
266a79f1db23a4a3bbddf09dadc68776ae8c4d56 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698