Issue 1351293002: Convert remaining scoped_ptr -> std::unique_ptr in //mojo/edk (minus js).

Issue 1351293002: Convert remaining scoped_ptr -> std::unique_ptr in //mojo/edk (minus js). (Closed)

Created:
5 years, 3 months ago by viettrungluu

Modified:
5 years, 3 months ago

Reviewers:
vardhan

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@edk_unique_ptr_5

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Convert remaining scoped_ptr -> std::unique_ptr in //mojo/edk (minus js). R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/f7745b6d73bd8a9d7c39ec0cf604ac428536fd98

Patch Set 1 #

Patch Set 2 : oops, forgot to fix android #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -41 lines)			Patch
M	mojo/android/javatests/init_library.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	mojo/dart/dart_snapshotter/main.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	mojo/edk/embedder/BUILD.gn	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	mojo/edk/embedder/embedder.h	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	mojo/edk/embedder/embedder.cc	View		3 chunks	+2 lines, -3 lines	0 comments	Download
M	mojo/edk/embedder/embedder_unittest.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	mojo/edk/embedder/platform_channel_pair.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	mojo/edk/embedder/platform_channel_utils_posix.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	mojo/edk/embedder/platform_handle_vector.h	View		3 chunks	+4 lines, -3 lines	0 comments	Download
M	mojo/edk/embedder/test_embedder.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	mojo/edk/system/channel.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	mojo/edk/system/master_connection_manager.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/edk/system/raw_channel.cc	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	mojo/edk/system/raw_channel_posix.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	mojo/edk/system/raw_channel_unittest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	mojo/edk/system/transport_data.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	mojo/nacl/monacl_shell.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	mojo/nacl/monacl_shell_nonsfi.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	mojo/python/system/mojo_embedder.pyx	View		3 chunks	+8 lines, -6 lines	0 comments	Download
M	shell/child_main.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	shell/context.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

5 years, 3 months ago (2015-09-18 15:35:03 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
f7745b6d73bd8a9d7c39ec0cf604ac428536fd98 (presubmit successful).

Expand Messages | Collapse Messages