Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1352883002: Fix Ganesh perspective projection bug (Closed)

Created:
5 years, 3 months ago by robertphillips
Modified:
5 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix Ganesh perspective projection bug #

Total comments: 2

Patch Set 3 : fixed overlength line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M src/gpu/gl/GrGLProgram.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp View 1 2 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
robertphillips
5 years, 3 months ago (2015-09-17 16:30:08 UTC) #2
jvanverth1
lgtm
5 years, 3 months ago (2015-09-17 16:31:33 UTC) #3
joshualitt
nit https://codereview.chromium.org/1352883002/diff/20001/src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp File src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp (right): https://codereview.chromium.org/1352883002/diff/20001/src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp#newcode61 src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp:61: "gl_Position = vec4(_posTmp.x * %s.x + %s.y, _posTmp.y ...
5 years, 3 months ago (2015-09-17 16:40:51 UTC) #5
robertphillips
https://codereview.chromium.org/1352883002/diff/20001/src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp File src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp (right): https://codereview.chromium.org/1352883002/diff/20001/src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp#newcode61 src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp:61: "gl_Position = vec4(_posTmp.x * %s.x + %s.y, _posTmp.y * ...
5 years, 3 months ago (2015-09-17 16:45:41 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1352883002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1352883002/40001
5 years, 3 months ago (2015-09-17 16:46:31 UTC) #8
joshualitt
On 2015/09/17 16:46:31, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
5 years, 3 months ago (2015-09-17 16:57:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1352883002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1352883002/40001
5 years, 3 months ago (2015-09-17 17:34:56 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 18:21:10 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/ef4ba3da0b1fe375b9631bcd17c43c645f4aa5a6

Powered by Google App Engine
This is Rietveld 408576698