Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1352813003: add a ClassID function to GrBatch (Closed)

Created:
5 years, 3 months ago by joshua.litt
Modified:
5 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : tweaks #

Total comments: 5

Patch Set 3 : tweaks #

Patch Set 4 : ptal #

Total comments: 1

Patch Set 5 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -100 lines) Patch
M gm/beziereffects.cpp View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M gm/convexpolyeffect.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 1 2 5 chunks +6 lines, -3 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 1 2 14 chunks +35 lines, -20 lines 0 comments Download
M src/gpu/batches/GrAAConvexPathRenderer.cpp View 1 2 4 chunks +4 lines, -3 lines 0 comments Download
M src/gpu/batches/GrAADistanceFieldPathRenderer.cpp View 1 2 3 chunks +6 lines, -2 lines 0 comments Download
M src/gpu/batches/GrAAHairLinePathRenderer.cpp View 1 2 3 chunks +5 lines, -2 lines 0 comments Download
M src/gpu/batches/GrAALinearizingConvexPathRenderer.cpp View 1 2 3 chunks +5 lines, -2 lines 0 comments Download
M src/gpu/batches/GrAAStrokeRectBatch.h View 1 2 3 chunks +6 lines, -2 lines 0 comments Download
M src/gpu/batches/GrBatch.h View 1 2 3 4 6 chunks +26 lines, -15 lines 0 comments Download
M src/gpu/batches/GrBatch.cpp View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/batches/GrClearBatch.h View 1 2 3 chunks +12 lines, -4 lines 0 comments Download
M src/gpu/batches/GrCopySurfaceBatch.h View 1 2 3 chunks +6 lines, -2 lines 0 comments Download
M src/gpu/batches/GrDefaultPathRenderer.cpp View 1 2 3 chunks +6 lines, -2 lines 0 comments Download
M src/gpu/batches/GrDiscardBatch.h View 1 2 2 chunks +6 lines, -2 lines 0 comments Download
M src/gpu/batches/GrDrawAtlasBatch.h View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M src/gpu/batches/GrDrawAtlasBatch.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/batches/GrDrawBatch.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrDrawBatch.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrDrawPathBatch.h View 1 2 4 chunks +9 lines, -5 lines 0 comments Download
M src/gpu/batches/GrDrawPathBatch.cpp View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/batches/GrDrawVerticesBatch.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M src/gpu/batches/GrDrawVerticesBatch.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/batches/GrStencilPathBatch.h View 1 2 3 chunks +6 lines, -2 lines 0 comments Download
M src/gpu/batches/GrStrokeRectBatch.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M src/gpu/batches/GrStrokeRectBatch.cpp View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M src/gpu/batches/GrTInstanceBatch.h View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M src/gpu/batches/GrTessellatingPathRenderer.cpp View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M src/gpu/batches/GrTestBatch.h View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M src/gpu/batches/GrVertexBatch.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrVertexBatch.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 1 2 4 chunks +7 lines, -3 lines 0 comments Download
M tests/GrPorterDuffTest.cpp View 1 2 2 chunks +8 lines, -1 line 0 comments Download

Dependent Patchsets:

Issue 1353683003 Patch 1
Issue 1353683003 Patch 20001
Issue 1353683003 Patch 40001

Messages

Total messages: 17 (6 generated)
joshualitt
ptal, I think the GrTInstanceBatch template will do the right thing.
5 years, 3 months ago (2015-09-17 14:20:54 UTC) #2
robertphillips
https://codereview.chromium.org/1352813003/diff/20001/src/gpu/GrAtlasTextContext.cpp File src/gpu/GrAtlasTextContext.cpp (right): https://codereview.chromium.org/1352813003/diff/20001/src/gpu/GrAtlasTextContext.cpp#newcode1446 src/gpu/GrAtlasTextContext.cpp:1446: Can this be first ? Everywhere else too ? ...
5 years, 3 months ago (2015-09-17 14:56:06 UTC) #3
joshualitt
ptal
5 years, 3 months ago (2015-09-17 16:43:08 UTC) #4
robertphillips
lgtm + a question https://codereview.chromium.org/1352813003/diff/60001/src/gpu/batches/GrBatch.cpp File src/gpu/batches/GrBatch.cpp (right): https://codereview.chromium.org/1352813003/diff/60001/src/gpu/batches/GrBatch.cpp#newcode51 src/gpu/batches/GrBatch.cpp:51: #if GR_BATCH_SPEW Did we just ...
5 years, 3 months ago (2015-09-17 16:58:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1352813003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1352813003/80001
5 years, 3 months ago (2015-09-17 17:11:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1352813003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1352813003/80001
5 years, 3 months ago (2015-09-17 17:29:09 UTC) #11
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://skia.googlesource.com/skia/+/4078d529e9e199eea13456db7bf3a63a104ab5b9
5 years, 3 months ago (2015-09-17 18:21:21 UTC) #12
joshualitt
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/1345393003/ by joshualitt@google.com. ...
5 years, 3 months ago (2015-09-17 18:42:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1352813003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1352813003/80001
5 years, 3 months ago (2015-09-17 18:50:04 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://skia.googlesource.com/skia/+/eb44d53cf96a7eaf103a98d76079ce1f5495e343
5 years, 3 months ago (2015-09-17 18:51:00 UTC) #16
reed2
5 years, 3 months ago (2015-09-18 00:34:42 UTC) #17
Message was sent while issue was closed. 
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1353043002/ by reed@chromium.org.

The reason for reverting is: Speculative revert to unblock DEPS roll.

Powered by Google App Engine
This is Rietveld 408576698