Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1353683003: Move StrokeRectBatches into .cpp files (Closed)

Created:
5 years, 3 months ago by joshua.litt
Modified:
5 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@statics
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move StrokeRectBatches into .cpp files BUG=skia: Committed: https://skia.googlesource.com/skia/+/3566d44d852b2fc1773e41e80c0c19610aa6d43b

Patch Set 1 #

Patch Set 2 : tweaks #

Patch Set 3 : tweaks #

Total comments: 2

Patch Set 4 : feedback inc #

Patch Set 5 : tweaks #

Patch Set 6 : moved perspective check for non aa fill rect to rect factory #

Patch Set 7 : tweaks #

Total comments: 5

Patch Set 8 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+458 lines, -431 lines) Patch
M gyp/gpu.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrBatchTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/batches/GrAAStrokeRectBatch.h View 1 2 3 4 1 chunk +10 lines, -96 lines 0 comments Download
M src/gpu/batches/GrAAStrokeRectBatch.cpp View 1 2 3 7 chunks +138 lines, -24 lines 0 comments Download
M src/gpu/batches/GrNonAAFillRectBatch.h View 1 2 3 4 5 1 chunk +8 lines, -0 lines 0 comments Download
M src/gpu/batches/GrNonAAFillRectBatch.cpp View 1 2 3 4 5 1 chunk +44 lines, -39 lines 0 comments Download
A + src/gpu/batches/GrNonAAStrokeRectBatch.h View 1 1 chunk +10 lines, -6 lines 0 comments Download
A src/gpu/batches/GrNonAAStrokeRectBatch.cpp View 1 2 3 4 5 6 7 1 chunk +226 lines, -0 lines 0 comments Download
M src/gpu/batches/GrRectBatchFactory.h View 1 2 3 4 5 3 chunks +15 lines, -7 lines 0 comments Download
M src/gpu/batches/GrRectBatchFactory.cpp View 3 chunks +3 lines, -33 lines 0 comments Download
D src/gpu/batches/GrStrokeRectBatch.h View 1 chunk +0 lines, -83 lines 0 comments Download
D src/gpu/batches/GrStrokeRectBatch.cpp View 1 chunk +0 lines, -139 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
joshualitt
mostly just a cleanup
5 years, 3 months ago (2015-09-17 19:49:56 UTC) #2
robertphillips
https://codereview.chromium.org/1353683003/diff/40001/src/gpu/batches/GrAAStrokeRectBatch.cpp File src/gpu/batches/GrAAStrokeRectBatch.cpp (right): https://codereview.chromium.org/1353683003/diff/40001/src/gpu/batches/GrAAStrokeRectBatch.cpp#newcode489 src/gpu/batches/GrAAStrokeRectBatch.cpp:489: GrColor color = GrRandomColor(random); It seems odd to copy ...
5 years, 3 months ago (2015-09-17 20:02:52 UTC) #3
joshualitt
On 2015/09/17 20:02:52, robertphillips wrote: > https://codereview.chromium.org/1353683003/diff/40001/src/gpu/batches/GrAAStrokeRectBatch.cpp > File src/gpu/batches/GrAAStrokeRectBatch.cpp (right): > > https://codereview.chromium.org/1353683003/diff/40001/src/gpu/batches/GrAAStrokeRectBatch.cpp#newcode489 > ...
5 years, 3 months ago (2015-09-17 20:07:14 UTC) #4
robertphillips
lgtm + nits https://codereview.chromium.org/1353683003/diff/120001/src/gpu/batches/GrNonAAStrokeRectBatch.cpp File src/gpu/batches/GrNonAAStrokeRectBatch.cpp (right): https://codereview.chromium.org/1353683003/diff/120001/src/gpu/batches/GrNonAAStrokeRectBatch.cpp#newcode75 src/gpu/batches/GrNonAAStrokeRectBatch.cpp:75: LocalCoords localCoords(this->usesLocalCoords() ? LocalCoords::kUsePosition_Type : line ...
5 years, 3 months ago (2015-09-18 13:27:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1353683003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1353683003/140001
5 years, 3 months ago (2015-09-18 14:06:30 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 14:12:59 UTC) #9
Message was sent while issue was closed. 
Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/3566d44d852b2fc1773e41e80c0c19610aa6d43b

Powered by Google App Engine
This is Rietveld 408576698