Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1352683006: Move device opening from DeviceManager to Device. (Closed)

Created:
5 years, 3 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 3 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move device opening from DeviceManager to Device. This makes the Device::GetConfiguration method callable even if the device is not open (which is good) and makes the Mojo interface closer to the WebUSB API. Committed: https://crrev.com/47fc2064019a963683a0682237c0ac58f754f713 Cr-Commit-Position: refs/heads/master@{#349968}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -240 lines) Patch
M content/renderer/usb/web_usb_client_impl.cc View 2 chunks +15 lines, -12 lines 0 comments Download
M content/renderer/usb/web_usb_device_impl.h View 2 chunks +2 lines, -4 lines 0 comments Download
M content/renderer/usb/web_usb_device_impl.cc View 4 chunks +3 lines, -14 lines 0 comments Download
M device/devices_app/usb/device_impl.h View 4 chunks +12 lines, -8 lines 0 comments Download
M device/devices_app/usb/device_impl.cc View 3 chunks +22 lines, -24 lines 0 comments Download
M device/devices_app/usb/device_impl_unittest.cc View 12 chunks +133 lines, -19 lines 0 comments Download
M device/devices_app/usb/device_manager_impl.h View 1 chunk +8 lines, -11 lines 0 comments Download
M device/devices_app/usb/device_manager_impl.cc View 2 chunks +22 lines, -86 lines 0 comments Download
M device/devices_app/usb/device_manager_impl_unittest.cc View 4 chunks +4 lines, -44 lines 0 comments Download
M device/devices_app/usb/public/interfaces/device.mojom View 2 chunks +19 lines, -5 lines 0 comments Download
M device/devices_app/usb/public/interfaces/device_manager.mojom View 2 chunks +2 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Reilly Grant (use Gerrit)
Please take a look. I like how this cleaned up the split between WebUSBClientImpl and ...
5 years, 3 months ago (2015-09-18 20:42:52 UTC) #2
Ken Rockot(use gerrit already)
lgtm
5 years, 3 months ago (2015-09-21 16:51:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1352683006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1352683006/1
5 years, 3 months ago (2015-09-21 17:11:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-21 18:28:28 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-21 18:29:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/47fc2064019a963683a0682237c0ac58f754f713
Cr-Commit-Position: refs/heads/master@{#349968}

Powered by Google App Engine
This is Rietveld 408576698