Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2777)

Unified Diff: device/devices_app/usb/public/interfaces/device_manager.mojom

Issue 1352683006: Move device opening from DeviceManager to Device. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/devices_app/usb/public/interfaces/device.mojom ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/devices_app/usb/public/interfaces/device_manager.mojom
diff --git a/device/devices_app/usb/public/interfaces/device_manager.mojom b/device/devices_app/usb/public/interfaces/device_manager.mojom
index ca394c5fbc69ac90b613c1a911735b551465afd5..fa8bb75c0954e2ccfbf6e3de17301de5a5250e67 100644
--- a/device/devices_app/usb/public/interfaces/device_manager.mojom
+++ b/device/devices_app/usb/public/interfaces/device_manager.mojom
@@ -6,17 +6,6 @@ module device.usb;
import "device.mojom";
-enum OpenDeviceError {
- // Opening the device succeeded.
- OK,
-
- // The device could not be opened because the request GUID is unknown.
- NOT_FOUND,
-
- // The operating system denied access to the device.
- ACCESS_DENIED,
-};
-
struct DeviceFilter {
bool has_vendor_id;
uint16 vendor_id;
@@ -53,6 +42,6 @@ interface DeviceManager {
// and removed between calls will not be included.
GetDeviceChanges() => (DeviceChangeNotification changes);
- // Attempts to open a device given its GUID.
- OpenDevice(string guid, Device& device_request) => (OpenDeviceError error);
+ // Requests a device by guid.
+ GetDevice(string guid, Device& device_request);
};
« no previous file with comments | « device/devices_app/usb/public/interfaces/device.mojom ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698