content/renderer/usb/web_usb_device_impl.h - Issue 1352683006: Move device opening from DeviceManager to Device.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/usb/web_usb_device_impl.h

Issue 1352683006: Move device opening from DeviceManager to Device. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/usb/web_usb_device_impl.h

diff --git a/content/renderer/usb/web_usb_device_impl.h b/content/renderer/usb/web_usb_device_impl.h

index 3f6eab52b1ef55a603a2abc0a82bf71c357b45fc..172817a3479cd1b90682871ec1f16f88632a61ce 100644

--- a/content/renderer/usb/web_usb_device_impl.h

+++ b/content/renderer/usb/web_usb_device_impl.h

@@ -23,7 +23,7 @@ namespace content {

class WebUSBDeviceImpl : public blink::WebUSBDevice {

public:

- WebUSBDeviceImpl(device::usb::DeviceManagerPtr device_manager,

+ WebUSBDeviceImpl(device::usb::DevicePtr device,

const blink::WebUSBDeviceInfo& device_info);

~WebUSBDeviceImpl() override;

@@ -61,10 +61,8 @@ class WebUSBDeviceImpl : public blink::WebUSBDevice {

blink::WebUSBDeviceBulkTransferCallbacks* callbacks) override;

void reset(blink::WebUSBDeviceResetCallbacks* callbacks) override;

- device::usb::DeviceManagerPtr device_manager_;

- blink::WebUSBDeviceInfo device_info_;

device::usb::DevicePtr device_;

+ blink::WebUSBDeviceInfo device_info_;

base::WeakPtrFactory<WebUSBDeviceImpl> weak_factory_;