Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1351473003: Refactor fake Connection subclasses in proximity_auth/ tests to a single file. (Closed)

Created:
5 years, 3 months ago by Tim Song
Modified:
5 years, 3 months ago
Reviewers:
sacomoto
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@client_rename
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor fake Connection subclasses in proximity_auth/ tests to a single file. BUG=527558 TEST=existing unit tests pass Committed: https://crrev.com/61a7c102df4f46e561bfca99f1f5989bb651476f Cr-Commit-Position: refs/heads/master@{#350696}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -140 lines) Patch
M components/proximity_auth.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M components/proximity_auth/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/proximity_auth/ble/bluetooth_low_energy_connection_finder_unittest.cc View 1 6 chunks +8 lines, -23 lines 0 comments Download
M components/proximity_auth/bluetooth_throttler_impl_unittest.cc View 2 chunks +2 lines, -14 lines 0 comments Download
A components/proximity_auth/fake_connection.h View 1 chunk +53 lines, -0 lines 0 comments Download
A components/proximity_auth/fake_connection.cc View 1 chunk +53 lines, -0 lines 0 comments Download
M components/proximity_auth/messenger_impl_unittest.cc View 3 chunks +2 lines, -53 lines 0 comments Download
M components/proximity_auth/remote_device_life_cycle_impl_unittest.cc View 1 2 9 chunks +20 lines, -35 lines 0 comments Download
M components/proximity_auth/throttled_bluetooth_connection_finder_unittest.cc View 3 chunks +3 lines, -15 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
Tim Song
5 years, 3 months ago (2015-09-16 18:27:42 UTC) #2
sacomoto
LGTM.
5 years, 3 months ago (2015-09-18 15:45:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1351473003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1351473003/40001
5 years, 3 months ago (2015-09-24 20:43:42 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/107551)
5 years, 3 months ago (2015-09-24 22:12:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1351473003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1351473003/40001
5 years, 3 months ago (2015-09-24 22:35:24 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-24 23:25:24 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 23:25:40 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/61a7c102df4f46e561bfca99f1f5989bb651476f
Cr-Commit-Position: refs/heads/master@{#350696}

Powered by Google App Engine
This is Rietveld 408576698