Refactor fake Connection subclasses in proximity_auth/ tests to a single file.

components/proximity_auth/ble/bluetooth_low_energy_connection_finder_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/proximity_auth/ble/bluetooth_low_energy_connection_finder.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "components/proximity_auth/ble/bluetooth_low_energy_device_whitelist.h"
-#include "components/proximity_auth/connection.h"
+#include "components/proximity_auth/fake_connection.h"
 #include "components/proximity_auth/remote_device.h"
 #include "components/proximity_auth/wire_message.h"
 #include "device/bluetooth/bluetooth_adapter_factory.h"
 #include "device/bluetooth/bluetooth_uuid.h"
 #include "device/bluetooth/test/mock_bluetooth_adapter.h"
 #include "device/bluetooth/test/mock_bluetooth_device.h"
 #include "device/bluetooth/test/mock_bluetooth_discovery_session.h"
 #include "device/bluetooth/test/mock_bluetooth_gatt_connection.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 16 matching lines @@
 const char kServiceUUID[] = "DEADBEEF-CAFE-FEED-FOOD-D15EA5EBEEEF";
 const char kOtherUUID[] = "AAAAAAAA-AAAA-AAAA-AAAA-D15EA5EBEEEF";
 
 const int kMaxNumberOfAttempts = 2;
 
 RemoteDevice CreateRemoteDevice() {
   return RemoteDevice(kDeviceName, kPublicKey, kBluetoothAddress,
                       kPersistentSymmetricKey);
 }
 
-class MockConnection : public Connection {
- public:
-  MockConnection() : Connection(CreateRemoteDevice()) {}
-  ~MockConnection() override {}
-
-  MOCK_METHOD0(Connect, void());
-
-  using Connection::SetStatus;
-
- private:
-  void Disconnect() override {}
-  void SendMessageImpl(scoped_ptr<WireMessage> message) override {}
-
-  DISALLOW_COPY_AND_ASSIGN(MockConnection);
-};
-
 class MockBluetoothLowEnergyDeviceWhitelist
     : public BluetoothLowEnergyDeviceWhitelist {
  public:
   MockBluetoothLowEnergyDeviceWhitelist()
       : BluetoothLowEnergyDeviceWhitelist(nullptr) {}
   ~MockBluetoothLowEnergyDeviceWhitelist() override {}
 
   MOCK_CONST_METHOD1(HasDeviceWithAddress, bool(const std::string&));
 };
 
@@ skipping 15 matching lines @@
   // Mock methods don't support return type scoped_ptr<>. This is a possible
   // workaround: mock a proxy method to be called by the target overrided method
   // (CreateConnection).
   MOCK_METHOD0(CreateConnectionProxy, Connection*());
 
   // Creates a mock connection and sets an expectation that the mock connection
   // finder's CreateConnection() method will be called and will return the
   // created connection. Returns a reference to the created connection.
   // NOTE: The returned connection's lifetime is managed by the connection
   // finder.
-  MockConnection* ExpectCreateConnection() {
-    scoped_ptr<MockConnection> connection(new NiceMock<MockConnection>());
-    MockConnection* connection_alias = connection.get();
+  FakeConnection* ExpectCreateConnection() {
+    scoped_ptr<FakeConnection> connection(
+        new FakeConnection(CreateRemoteDevice()));
+    FakeConnection* connection_alias = connection.get();
     EXPECT_CALL(*this, CreateConnectionProxy())
         .WillOnce(Return(connection.release()));
     return connection_alias;
   }
 
   MOCK_METHOD0(CloseGattConnectionProxy, void(void));
 
  protected:
   scoped_ptr<Connection> CreateConnection(
       const std::string& device_address) override {
@@ skipping 264 matching lines @@
 
 TEST_F(ProximityAuthBluetoothLowEnergyConnectionFinderTest,
        Find_ConnectionSucceeds_WithRemoteDevice) {
   StrictMock<MockBluetoothLowEnergyConnectionFinder> connection_finder(
       nullptr, BluetoothLowEnergyConnectionFinder::FIND_PAIRED_DEVICE);
   // Starting discovery.
   FindAndExpectStartDiscovery(connection_finder);
   ExpectStopDiscoveryAndRemoveObserver();
 
   // Finding and creating a connection to the right device.
-  MockConnection* connection = connection_finder.ExpectCreateConnection();
+  FakeConnection* connection = connection_finder.ExpectCreateConnection();
   PrepareDevice(kServiceUUID, kBluetoothAddress, true);
   connection_finder.DeviceAdded(adapter_.get(), device_.get());
 
   // Creating a connection.
   base::RunLoop run_loop;
   EXPECT_FALSE(last_found_connection_);
   connection->SetStatus(Connection::IN_PROGRESS);
   connection->SetStatus(Connection::CONNECTED);
   run_loop.RunUntilIdle();
   EXPECT_TRUE(last_found_connection_);
 }
 
 TEST_F(ProximityAuthBluetoothLowEnergyConnectionFinderTest,
        Find_ConnectionFails_RestartDiscoveryAndConnectionSucceeds) {
   StrictMock<MockBluetoothLowEnergyConnectionFinder> connection_finder(
       nullptr, BluetoothLowEnergyConnectionFinder::FIND_PAIRED_DEVICE);
 
   // Starting discovery.
   FindAndExpectStartDiscovery(connection_finder);
   base::Closure stop_discovery_session_callback;
   EXPECT_CALL(*last_discovery_session_alias_, Stop(_, _))
       .WillOnce(SaveArg<0>(&stop_discovery_session_callback));
 
   // Preparing to create a GATT connection to the right device.
   PrepareDevice(kServiceUUID, kBluetoothAddress, true);
-  MockConnection* connection = connection_finder.ExpectCreateConnection();
+  FakeConnection* connection = connection_finder.ExpectCreateConnection();
 
   // Trying to create a connection.
   connection_finder.DeviceAdded(adapter_.get(), device_.get());
   ASSERT_FALSE(last_found_connection_);
   connection->SetStatus(Connection::IN_PROGRESS);
 
   // Stopping the discovery session.
   ASSERT_FALSE(stop_discovery_session_callback.is_null());
   stop_discovery_session_callback.Run();
 
@@ skipping 64 matching lines @@
   connection_finder.AdapterPresentChanged(adapter_.get(), true);
   connection_finder.AdapterPoweredChanged(adapter_.get(), true);
   ON_CALL(*last_discovery_session_alias_, IsActive())
       .WillByDefault(Return(true));
 
   ASSERT_FALSE(discovery_callback.is_null());
   discovery_callback.Run(discovery_session.Pass());
 
   // Preparing to create a GATT connection to the right device.
   PrepareDevice(kServiceUUID, kBluetoothAddress, true);
-  MockConnection* connection = connection_finder.ExpectCreateConnection();
+  FakeConnection* connection = connection_finder.ExpectCreateConnection();
 
   // Trying to create a connection.
   connection_finder.DeviceAdded(adapter_.get(), device_.get());
   EXPECT_CALL(*last_discovery_session_alias_, Stop(_, _)).Times(AtLeast(1));
 
   // Completing the connection.
   base::RunLoop run_loop;
   ASSERT_FALSE(last_found_connection_);
   connection->SetStatus(Connection::IN_PROGRESS);
   connection->SetStatus(Connection::CONNECTED);
   run_loop.RunUntilIdle();
   EXPECT_TRUE(last_found_connection_);
 }
 
 }  // namespace proximity_auth