Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 1352063002: Change chrome://proximity-auth to use RemoteDeviceLifeCycle. (Closed)

Created:
5 years, 3 months ago by Tim Song
Modified:
5 years, 2 months ago
Reviewers:
sacomoto
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@refactor_mocks
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update chrome://proximity-auth to use RemoteDeviceLifeCycle. BUG=527558 TEST=manual Committed: https://crrev.com/f3274a071078b5f0722733c946854e17db1a4602 Cr-Commit-Position: refs/heads/master@{#350864}

Patch Set 1 #

Patch Set 2 : fix some log messages #

Patch Set 3 : fix win compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -188 lines) Patch
M components/proximity_auth/bluetooth_connection_finder.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/proximity_auth/remote_device_life_cycle_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/proximity_auth/webui/proximity_auth_webui_handler.h View 6 chunks +10 lines, -41 lines 0 comments Download
M components/proximity_auth/webui/proximity_auth_webui_handler.cc View 1 2 7 chunks +39 lines, -146 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
Tim Song
5 years, 3 months ago (2015-09-18 00:19:04 UTC) #2
sacomoto
LGTM.
5 years, 3 months ago (2015-09-23 14:25:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1352063002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1352063002/60001
5 years, 2 months ago (2015-09-25 17:59:17 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 2 months ago (2015-09-25 18:06:11 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 18:06:53 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f3274a071078b5f0722733c946854e17db1a4602
Cr-Commit-Position: refs/heads/master@{#350864}

Powered by Google App Engine
This is Rietveld 408576698