mojo/nacl/monacl_shell_nonsfi.cc - Issue 1351293002: Convert remaining scoped_ptr -> std::unique_ptr in //mojo/edk (minus js).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/nacl/monacl_shell_nonsfi.cc

Issue 1351293002: Convert remaining scoped_ptr -> std::unique_ptr in //mojo/edk (minus js). (Closed) Base URL: https://github.com/domokit/mojo.git@edk_unique_ptr_5

Patch Set: oops, forgot to fix android Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/nacl/monacl_shell_nonsfi.cc

diff --git a/mojo/nacl/monacl_shell_nonsfi.cc b/mojo/nacl/monacl_shell_nonsfi.cc

index 0a2f7e2ab6a26d69eab0cc4643a8d9103168b0de..b90b19e4407476686268c2c7c6b29fc36924fdad 100644

--- a/mojo/nacl/monacl_shell_nonsfi.cc

+++ b/mojo/nacl/monacl_shell_nonsfi.cc

@@ -26,8 +26,9 @@ int main(int argc, char** argv, char** environ) {

}

uintptr_t entry = NaClLoadElfFile(fd);

- mojo::embedder::Init(scoped_ptr<mojo::embedder::PlatformSupport>(

- new mojo::embedder::SimplePlatformSupport()));

+ // TODO(vtl): Use make_unique when C++14 is available.

+ mojo::embedder::Init(std::unique_ptr<mojo::embedder::PlatformSupport>(

+ new mojo::embedder::SimplePlatformSupport()));

return nacl_irt_nonsfi_entry(argc - 1, argv + 1, environ,

reinterpret_cast<nacl_entry_func_t>(entry),

« no previous file with comments | « mojo/nacl/monacl_shell.cc ('k') | mojo/python/system/mojo_embedder.pyx » ('j') | no next file with comments »