Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: mojo/edk/embedder/test_embedder.cc

Issue 1351293002: Convert remaining scoped_ptr -> std::unique_ptr in //mojo/edk (minus js). (Closed) Base URL: https://github.com/domokit/mojo.git@edk_unique_ptr_5
Patch Set: oops, forgot to fix android Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « mojo/edk/embedder/platform_handle_vector.h ('k') | mojo/edk/system/channel.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/edk/embedder/test_embedder.h" 5 #include "mojo/edk/embedder/test_embedder.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/memory/scoped_ptr.h"
9 #include "mojo/edk/embedder/embedder.h" 8 #include "mojo/edk/embedder/embedder.h"
10 #include "mojo/edk/embedder/embedder_internal.h" 9 #include "mojo/edk/embedder/embedder_internal.h"
11 #include "mojo/edk/embedder/simple_platform_support.h" 10 #include "mojo/edk/embedder/simple_platform_support.h"
12 #include "mojo/edk/system/channel_manager.h" 11 #include "mojo/edk/system/channel_manager.h"
13 #include "mojo/edk/system/core.h" 12 #include "mojo/edk/system/core.h"
14 #include "mojo/edk/system/handle_table.h" 13 #include "mojo/edk/system/handle_table.h"
14 #include "mojo/edk/util/make_unique.h"
15 15
16 namespace mojo { 16 namespace mojo {
17 17
18 namespace system { 18 namespace system {
19 namespace internal { 19 namespace internal {
20 20
21 bool ShutdownCheckNoLeaks(Core* core) { 21 bool ShutdownCheckNoLeaks(Core* core) {
22 // No point in taking the lock. 22 // No point in taking the lock.
23 const HandleTable::HandleToEntryMap& handle_to_entry_map = 23 const HandleTable::HandleToEntryMap& handle_to_entry_map =
24 core->handle_table_.handle_to_entry_map_; 24 core->handle_table_.handle_to_entry_map_;
25 25
26 if (handle_to_entry_map.empty()) 26 if (handle_to_entry_map.empty())
27 return true; 27 return true;
28 28
29 for (HandleTable::HandleToEntryMap::const_iterator it = 29 for (HandleTable::HandleToEntryMap::const_iterator it =
30 handle_to_entry_map.begin(); 30 handle_to_entry_map.begin();
31 it != handle_to_entry_map.end(); ++it) { 31 it != handle_to_entry_map.end(); ++it) {
32 LOG(ERROR) << "Mojo embedder shutdown: Leaking handle " << (*it).first; 32 LOG(ERROR) << "Mojo embedder shutdown: Leaking handle " << (*it).first;
33 } 33 }
34 return false; 34 return false;
35 } 35 }
36 36
37 } // namespace internal 37 } // namespace internal
38 } // namespace system 38 } // namespace system
39 39
40 namespace embedder { 40 namespace embedder {
41 namespace test { 41 namespace test {
42 42
43 void InitWithSimplePlatformSupport() { 43 void InitWithSimplePlatformSupport() {
44 Init(make_scoped_ptr(new SimplePlatformSupport())); 44 Init(util::MakeUnique<SimplePlatformSupport>());
45 } 45 }
46 46
47 bool Shutdown() { 47 bool Shutdown() {
48 // If |InitIPCSupport()| was called, then |ShutdownIPCSupport()| must have 48 // If |InitIPCSupport()| was called, then |ShutdownIPCSupport()| must have
49 // been called first. 49 // been called first.
50 CHECK(!internal::g_ipc_support); 50 CHECK(!internal::g_ipc_support);
51 51
52 CHECK(internal::g_core); 52 CHECK(internal::g_core);
53 bool rv = system::internal::ShutdownCheckNoLeaks(internal::g_core); 53 bool rv = system::internal::ShutdownCheckNoLeaks(internal::g_core);
54 delete internal::g_core; 54 delete internal::g_core;
55 internal::g_core = nullptr; 55 internal::g_core = nullptr;
56 56
57 CHECK(internal::g_platform_support); 57 CHECK(internal::g_platform_support);
58 delete internal::g_platform_support; 58 delete internal::g_platform_support;
59 internal::g_platform_support = nullptr; 59 internal::g_platform_support = nullptr;
60 60
61 return rv; 61 return rv;
62 } 62 }
63 63
64 } // namespace test 64 } // namespace test
65 } // namespace embedder 65 } // namespace embedder
66 66
67 } // namespace mojo 67 } // namespace mojo
OLDNEW
« no previous file with comments | « mojo/edk/embedder/platform_handle_vector.h ('k') | mojo/edk/system/channel.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698